fix(request): unspecified location goes in body, also for blob #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luacheck Report2 tests 2 ✅ 0s ⏱️ Results for commit b07928d. ♻️ This comment has been updated with latest results. |
Tieske
commented
Jun 14, 2024
Contributor
Author
Tieske
left a comment
Tieske
left a comment
There was a problem hiding this comment.
needs a changelog entry
Tieske
force-pushed
the
fix/request-blob-body
branch
from
086c928 to
19b5a86
Compare
Contributor
Author
|
changelog entry added |
previously a "blob" type without location given would be added as a nested data element which was incorrect.
Tieske
force-pushed
the
fix/request-blob-body
branch
from
19b5a86 to
1ffb854
Compare
Member
|
Could you add a test for it? |
outsinre
previously approved these changes
Jun 17, 2024
outsinre
approved these changes
Jun 17, 2024
windmgc
approved these changes
Jun 17, 2024
windmgc
added a commit
that referenced
this pull request
Aug 2, 2024
This is a follow-up fix for #120 . The PR modifies the request build again with the following changes: when the payload field is specified inside the input schema, the request body will be built based on the parameter that specified by the payload field. This behavior imitates the behavior defined in aws-sdk-js: https://github.com/aws/aws-sdk-js/blob/02153340ce052614c5437fe46ab1f49bfd8483f7/lib/protocol/rest_json.js#L24-L41 as well as https://github.com/aws/aws-sdk-js/blob/02153340ce052614c5437fe46ab1f49bfd8483f7/lib/protocol/rest_xml.js#L10-L26 FTI-6138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously a "blob" type without location given would be added as a nested data element which was incorrect.
fixes #58