feat: upgrade metallb implemenation for 0.15.x #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the metallb implementation from 0.31, as the old implementation no longer works.
pmalek
previously approved these changes
Jul 7, 2023
Member
pmalek
left a comment
pmalek
left a comment
There was a problem hiding this comment.
This technically breaks semver because it's new functionality
We're pre v1 (do what you want/need) so that doesn't break semver.
Member
|
The CI is not functional though 😢 |
rainest
had a problem deploying
to
integration-tests
GitHub Actions
Failure
rainest
had a problem deploying
to
integration-tests
GitHub Actions
Failure
rainest
had a problem deploying
to
integration-tests
GitHub Actions
Failure
rainest
had a problem deploying
to
integration-tests
GitHub Actions
Failure
rainest
had a problem deploying
to
integration-tests
GitHub Actions
Failure
rainest
force-pushed
the
metallb-backport
branch
2 times, most recently
from
97dead0 to
76c5200
Compare
pmalek
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the metallb implementation from 0.31, as the old implementation no longer works.
To handle backports in KIC 2.5, we need to continue using KTF 0.15. KTF includes dependencies on client-go, GWAPI, etc., and upgrading those by pulling in the new KTF breaks API compatibility for 2.5. However, the 0.15 metallb addon no longer works.
This change pulls in the latest addon in its entirety and creating a release branch in prep to release a 0.15.2. This technically breaks semver because it's new functionality (although it does not break API compatibility), but I'm not sure what we can really do otherwise since we can't exactly bump the minor version (0.16 already exists). We may want to consider cutting new KTF major releases when we want to do a KIC LTS, although this tightly couples KTF version bumps to something it's not directly.