chore: cover credentials in KongClient golden tests #6575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6575 +/- ##
=======================================
+ Coverage 69.5% 72.5% +2.9%
=======================================
Files 202 202
Lines 25796 25801 +5
=======================================
+ Hits 17935 18711 +776
+ Misses 6853 6079 -774
- Partials 1008 1011 +3 ☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
test/cover-credentials-in-golden
branch
from
0226f5b
to
9a75228
Compare
czeslavo
force-pushed
the
test/cover-credentials-in-golden
branch
from
9a75228
to
c72861f
Compare
czeslavo
force-pushed
the
test/cover-credentials-in-golden
branch
from
c72861f
to
ec218fa
Compare
randmonkey
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In #6574 we suspected KIC doesn't set Kubernetes metadata tags for credential entities. This PR proves it's not the case by adding a KongClient golden test case that covers all credential types.
Which issue this PR fixes:
Closes #6574.