Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump gateway-api from 1.1.0 to 1.2.0 and adjust code #6571

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Oct 28, 2024

What this PR does / why we need it:

Bumps version of gateway-api from 1.1.0 to 1.2.0 and makes required adjustments to make code compile and test pass (bump KTF to v0.1.7).

Furthermore, change the sorting of headerMatches by names from slice.Sort to slice.StableSort to fulfill the code commenter's desire always to have the same order. Bumping the Go version to 1.23 is required to make linitng pass.

Which issue this PR fixes:

Replaces #6543

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@programmer04 programmer04 added dependencies Pull requests that update a dependency file area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Oct 28, 2024
@programmer04 programmer04 added this to the KIC v3.4.x milestone Oct 28, 2024
@programmer04 programmer04 self-assigned this Oct 28, 2024
@programmer04 programmer04 force-pushed the bump-gwapi branch 3 times, most recently from a7d39d9 to 87a71a4 Compare October 28, 2024 09:53
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.3%. Comparing base (35b1374) to head (3bea8d8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6571     +/-   ##
=======================================
+ Coverage   69.5%   72.3%   +2.7%     
=======================================
  Files        202     202             
  Lines      25796   25856     +60     
=======================================
+ Hits       17935   18694    +759     
+ Misses      6853    6150    -703     
- Partials    1008    1012      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 marked this pull request as ready for review October 28, 2024 12:33
@programmer04 programmer04 requested a review from a team as a code owner October 28, 2024 12:33
@programmer04 programmer04 enabled auto-merge (squash) October 28, 2024 12:33
@programmer04 programmer04 merged commit b5c61d2 into main Oct 28, 2024
42 checks passed
@programmer04 programmer04 deleted the bump-gwapi branch October 28, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. dependencies Pull requests that update a dependency file size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants