Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): migrate actions/upload-artifact and actions/download-artifact to v4 #5843

Merged
merged 2 commits into from
Apr 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/_conformance_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ jobs:
fail-fast: false
matrix:
include:
- name: conformance-tests-traditional-compatible-router
- name: traditional-compatible-router
expression_routes: "false"
- name: "conformance-tests-expressions-router"
- name: expressions-router
expression_routes: "true"
steps:
- name: checkout repository
Expand All @@ -55,22 +55,22 @@ jobs:
- name: run conformance tests
run: make test.conformance
env:
JUNIT_REPORT: "conformance-tests.xml"
JUNIT_REPORT: conformance-tests.xml
KONG_TEST_EXPRESSION_ROUTES: ${{ matrix.expression_routes }}
TEST_KONG_KIC_MANAGER_LOG_OUTPUT: ${{ inputs.log-output-file }}

# upload logs when test failed
- name: upload KIC logs
if: ${{ failure() && inputs.log-output-file != '' }}
uses: actions/upload-artifact@v3
with:
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.name }}-kic-logs
path: ${{ inputs.log-output-file }}
if-no-files-found: ignore

- name: collect test report
if: ${{ always() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: tests-report
name: tests-report-conformance-${{ matrix.name }}
path: conformance-tests.xml
8 changes: 4 additions & 4 deletions .github/workflows/_envtest_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ jobs:
GOTESTSUM_JUNITFILE: envtest-tests.xml

- name: collect test coverage
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage
name: coverage-envtest
path: coverage.envtest.out

- name: collect test report
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: tests-report
name: tests-report-envtest
path: envtest-tests.xml
12 changes: 6 additions & 6 deletions .github/workflows/_integration_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -192,14 +192,14 @@ jobs:

- name: collect test coverage
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage
name: coverage-${{ matrix.name }}
path: coverage.*.out

- name: upload diagnostics
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: diagnostics-integration-tests-${{ matrix.name }}
path: /tmp/ktf-diag*
Expand All @@ -208,15 +208,15 @@ jobs:
# upload logs when test failed
- name: upload KIC logs
if: ${{ failure() && inputs.log-output-file != '' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: integration-tests-kic-logs-${{ matrix.name }}
path: ${{ inputs.log-output-file }}
if-no-files-found: ignore

- name: collect test report
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: tests-report
name: tests-report-integration-${{ matrix.name }}
path: integration-tests-${{ matrix.name }}.xml
8 changes: 4 additions & 4 deletions .github/workflows/_kongintegration_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ jobs:
TEST_KONG_KONNECT_ACCESS_TOKEN: ${{ secrets.K8S_TEAM_KONNECT_ACCESS_TOKEN }}

- name: collect test coverage
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage
name: coverage-kongintegration
path: "coverage.*.out"

- name: collect test report
if: always()
uses: actions/upload-artifact@v3
with:
name: tests-report
path: "*-tests.xml"
name: tests-report-kongintegration
path: kongintegration-tests.xml
10 changes: 6 additions & 4 deletions .github/workflows/_test_reports.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@ jobs:

- name: collect test coverage artifacts
id: download-coverage
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: coverage
pattern: coverage-*
path: coverage
merge-multiple: true

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
Expand All @@ -51,10 +52,11 @@ jobs:

- name: download tests report
id: download-coverage
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: tests-report
pattern: tests-report-*
path: report
merge-multiple: true

- name: Upload test results to BuildPulse for flaky test detection
if: ${{ !cancelled() }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/_unit_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ jobs:
GOTESTSUM_JUNITFILE: unit-tests.xml

- name: collect test coverage
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage
name: coverage-unit
path: coverage.unit.out

- name: collect test report
if: ${{ always() }}
uses: actions/upload-artifact@v3
with:
name: tests-report
name: tests-report-unit
path: unit-tests.xml
Loading