Upgrade 2.12 branch KTF to v0.46 #5759
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update KTF to to v0.46. This in turn requires migrating from deck to go-database-reconciler and migrating (most) Gateway API imports from v1beta to v1. Use stub values for FillIDs workspaces. This does not include the complete fix from 0314607 and retains the original bug from 2.x. Same name entities across workspaces will still conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrade KTF on the 2.12.x branch. This pulls in two major package changes:
Which issue this PR fixes:
Should fix Kuma test issues.
Special notes for your reviewer:
Although the package updates are significant, I do not expect them to introduce breaking changes. GWAPI APIs should handled by Kubernetes CRD conversions (the version we use doesn't matter, the version on the cluster does--Kubernetes will convert the storage version to the requested version as needed if they're compatible, and AFAIK they are). GDR, aside from the following, is basically the same code as deck with different names. We may have pulled in some extra bugfixes and features 2.x doesn't use, but I'm expecting tests to catch any issues that may introduce.
GDR updates want to include the #5401 fix for same-name entity ID collisions across workspace. This backport does not integrate that fix and simply passes an empty string to
FillIDs(), as that fix is tied up in several broader changes to how we manage the parser. It's probably possible to backport this, but I don't think the bug is severe enough to warrant it--I think it's reasonable to ask affected users to upgrade to 3.x if they need to avoid those conflicts. We can reconsider that pending demand for a 2.x fix.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:theshould not result in user-facing changes.CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR