fix: restore defaulting to protocol "grpcs" for gRPC Service #5283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Heuristic introduced in #5128 for guessing whether for Kong Service
grpc
orgrpcs
protocol should be set breaks default behavior, that service without annotation forGRPCRoute
is treated asgrpcs
.Now documentation always mentions annotations for both
grpc
andgrpcs
seebut before when only gRPC over HTTPS was supported annotations weren't mentioned. Thus users probably haven't configured it and we have to avoid breaking their setups. This PR ensures that such a configuration will work.
Which issue this PR fixes:
Part of #4273
Special notes for your reviewer:
grpcs
is indeed broken (the same setup as described in the docs before the update)getProtocolForKongService(...)
and some small clean-ups and improvementsPR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR