Revert "chore(test): skip test when only docs be changed (#5207)" #5225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3d5935e.
1 task
czeslavo
approved these changes
Nov 22, 2023
|
For posterity: this is to unblock #5221 which was affected. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5225 +/- ##
=======================================
- Coverage 76.8% 74.5% -2.3%
=======================================
Files 170 170
Lines 19056 19056
=======================================
- Hits 14644 14212 -432
- Misses 3586 4016 +430
- Partials 826 828 +2 ☔ View full report in Codecov by Sentry. |
|
Sorry, let me fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3d5935e.
What this PR does / why we need it:
Job
passedis set as required in configuration of branch protection rules for themain. Hence when a file that matches pattern for skipping is edited in the PR it will get stuck forever as hereThe above is a real-world case hit in PR #5207.
Revert it to get it run again, and reopen a related issue.
Which issue this PR fixes:
Reopens #5206