feat: LB IP missing no longer an error #4066
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this commit a LoadBalancer service that has no external IP
addresses listed in the status is no longer a reconciliation error.
We're changing the semtantics from "KIC failed to reconcile" to
"KIC reconciled this publish service okay, it just happens to have
zero public IP addresses".
Why are we making this change? To allow for a more user-friendly
message than this:
[kong-controller-75896f8d9b-4hwbq] time="2023-05-24T11:26:03Z" level=error msg="Reconciler error" error="waiting for addresses to be provisioned for publish service kong/kong-proxy-proxy" logger=controllers.Ingress.netv1 reconcileID="\"f97e4634-0d72-4882-bdd9-9a5b2e5339b6\""
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4066 +/- ##
=====================================
Coverage 59.9% 60.0%
=====================================
Files 149 149
Lines 16491 16491
=====================================
+ Hits 9884 9895 +11
+ Misses 5975 5965 -10
+ Partials 632 631 -1
☔ View full report in Codecov by Sentry. |
|
@mflendrich do we want to merge this?
Where did we encounter that? I can see the benefit of this change but I'm curious about where did this come up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this commit a LoadBalancer service that has no external IP addresses listed in the status is no longer a reconciliation error - the intended result is:
a change from the ugly error below to a more informative message to the user
[kong-controller-75896f8d9b-4hwbq] time="2023-05-24T11:26:03Z" level=error msg="Reconciler error" error="waiting for addresses to be provisioned for publish service kong/kong-proxy-proxy" logger=controllers.Ingress.netv1 reconcileID=""f97e4634-0d72-4882-bdd9-9a5b2e5339b6""
not requeueing reconciliation of the ingress in the event of the LB service not being ready (yet)
We're changing the semtantics from "KIC failed to reconcile" to "KIC reconciled this publish service okay, it just happens to have zero public IP addresses".
Why are we making this change? To allow for a more user-friendly message than this: