Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generator dependency updates #1754

Merged
merged 6 commits into from
Aug 26, 2021
Merged

chore: generator dependency updates #1754

merged 6 commits into from
Aug 26, 2021

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Aug 25, 2021

What this PR does / why we need it:

A small maintenance item to update some of our Makefile dependencies for code generation. Dependabot is not able to target an update these.

I ran all the generators, other than indicating the new version of controller-gen changes are minimal.

@shaneutt shaneutt added priority/low area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Aug 25, 2021
@shaneutt shaneutt self-assigned this Aug 25, 2021
@shaneutt shaneutt requested a review from a team as a code owner August 25, 2021 18:13
@shaneutt shaneutt temporarily deployed to Configure ci August 25, 2021 18:21 Inactive
rainest
rainest previously approved these changes Aug 25, 2021
@rainest
Copy link
Contributor

rainest commented Aug 25, 2021

make manifests.single should fix the lint error.

@rainest
Copy link
Contributor

rainest commented Aug 25, 2021

Or maybe not. Is your kustomize version also 4.3.0? The failures are whitespace differences, which are usually because kustomize updated some rule about where it indents and inserts newlines.

The Arch package is still 4.2, so maybe that?

@shaneutt shaneutt temporarily deployed to Configure ci August 25, 2021 19:07 Inactive
@shaneutt
Copy link
Contributor Author

Or maybe not. Is your kustomize version also 4.3.0? The failures are whitespace differences, which are usually because kustomize updated some rule about where it indents and inserts newlines.

The Arch package is still 4.2, so maybe that?

locally I'm getting:

$ make verify.manifests
./hack/verify-manifests.sh
./hack/../deploy/single-v2/ up to date.
Updated 0 paths from the index

So that's great. Still digging.

@shaneutt shaneutt marked this pull request as draft August 25, 2021 19:30
@shaneutt shaneutt temporarily deployed to Configure ci August 25, 2021 19:39 Inactive
@rainest
Copy link
Contributor

rainest commented Aug 25, 2021

Right, yeah--if you build and verify on the same version, it will work. If you verify using a different version, it may generate differently and the comparison will fail.

@rainest rainest temporarily deployed to Configure ci August 25, 2021 21:17 Inactive
@rainest rainest marked this pull request as ready for review August 25, 2021 21:22
@shaneutt shaneutt enabled auto-merge (squash) August 26, 2021 13:17
@shaneutt shaneutt temporarily deployed to Configure ci August 26, 2021 15:33 Inactive
@shaneutt shaneutt merged commit 9573d89 into main Aug 26, 2021
@shaneutt shaneutt deleted the generator-updates branch August 26, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. ci/license/unchanged priority/low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants