-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: generator dependency updates #1754
Conversation
|
9ef66fb
to
78619e7
Compare
Or maybe not. Is your kustomize version also 4.3.0? The failures are whitespace differences, which are usually because kustomize updated some rule about where it indents and inserts newlines. The Arch package is still 4.2, so maybe that? |
locally I'm getting:
So that's great. Still digging. |
ff2ca61
to
78619e7
Compare
Right, yeah--if you build and verify on the same version, it will work. If you verify using a different version, it may generate differently and the comparison will fail. |
What this PR does / why we need it:
A small maintenance item to update some of our
Makefile
dependencies for code generation. Dependabot is not able to target an update these.I ran all the generators, other than indicating the new version of
controller-gen
changes are minimal.