Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: seperate latest k8s release tests #1621

Merged
merged 2 commits into from
Jul 30, 2021
Merged

chore: seperate latest k8s release tests #1621

merged 2 commits into from
Jul 30, 2021

Conversation

shaneutt
Copy link
Contributor

What this PR does / why we need it:

In another upcoming change we're switching testing
of older kubernetes releases onto GKE (from KIND)
so that they're running against conformant production
quality cluster configurations. This patch moves
the tests which must remain in kind (for now) into
their own job as a blocker for releases.

Which issue this PR fixes

Resolves #1616

In another upcoming change we're switching testing
of older kubernetes releases onto GKE (from KIND)
so that they're running against conformant production
quality cluster configurations. This patch moves
the tests which must remain in kind (for now) into
their own job as a blocker for releases.
@shaneutt shaneutt added area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Jul 30, 2021
@shaneutt shaneutt self-assigned this Jul 30, 2021
@shaneutt shaneutt requested a review from a team as a code owner July 30, 2021 15:54
@shaneutt shaneutt linked an issue Jul 30, 2021 that may be closed by this pull request
3 tasks
@shaneutt shaneutt requested a review from ccfishk July 30, 2021 15:59
@Kong Kong deleted a comment from codecov bot Jul 30, 2021
@shaneutt shaneutt enabled auto-merge (squash) July 30, 2021 16:06
@Kong Kong deleted a comment from codecov bot Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #1621 (5fb8fd7) into next (e135f44) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1621      +/-   ##
==========================================
- Coverage   62.39%   62.30%   -0.10%     
==========================================
  Files          82       82              
  Lines        7202     7202              
==========================================
- Hits         4494     4487       -7     
- Misses       2381     2386       +5     
- Partials      327      329       +2     
Flag Coverage Δ
integration-test 62.30% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/ctrlutils/ingress-status.go 60.00% <0.00%> (-1.25%) ⬇️
internal/parser/parser.go 87.67% <0.00%> (-1.15%) ⬇️
internal/ctrlutils/utils.go 95.83% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e135f44...5fb8fd7. Read the comment docs.

Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with the split proposed here itself; I do have other questions I'll raise elsewhere.

@shaneutt shaneutt merged commit b4b8165 into next Jul 30, 2021
@shaneutt shaneutt deleted the release-test-latest branch July 30, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. ci/license/unchanged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Testing: Latest Kubernetes
3 participants