Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] stop status updates on 404 #1620

Merged
merged 1 commit into from
Jul 30, 2021
Merged

[fix] stop status updates on 404 #1620

merged 1 commit into from
Jul 30, 2021

Conversation

shaneutt
Copy link
Contributor

What this PR does / why we need it:

If we're processing status updates for an object, but that object is removed from the API while we're working on it, we should stop working on it.

Which issue this PR fixes

Resolves #1619

@shaneutt shaneutt added bug Something isn't working priority/medium labels Jul 30, 2021
@shaneutt shaneutt self-assigned this Jul 30, 2021
@shaneutt shaneutt requested a review from a team as a code owner July 30, 2021 15:38
@shaneutt shaneutt linked an issue Jul 30, 2021 that may be closed by this pull request
1 task
Copy link
Contributor

@ccfishk ccfishk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kong Kong deleted a comment from codecov bot Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #1620 (f579349) into next (6042cfd) will decrease coverage by 0.26%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1620      +/-   ##
==========================================
- Coverage   62.56%   62.30%   -0.27%     
==========================================
  Files          82       82              
  Lines        7180     7202      +22     
==========================================
- Hits         4492     4487       -5     
- Misses       2361     2384      +23     
- Partials      327      331       +4     
Flag Coverage Δ
integration-test 62.30% <12.50%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/ctrlutils/ingress-status.go 60.93% <12.50%> (-5.17%) ⬇️
internal/ctrlutils/utils.go 93.75% <0.00%> (-2.09%) ⬇️
...trollers/configuration/zz_generated_controllers.go 33.61% <0.00%> (-1.02%) ⬇️
internal/parser/parser.go 88.82% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6042cfd...f579349. Read the comment docs.

@ccfishk ccfishk merged commit e135f44 into next Jul 30, 2021
@ccfishk ccfishk deleted the stop-status-updates-on-404 branch July 30, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress Status Updates fail for missing objects
2 participants