Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up coverage #1611

Merged
merged 1 commit into from
Jul 30, 2021
Merged

chore: clean up coverage #1611

merged 1 commit into from
Jul 30, 2021

Conversation

shaneutt
Copy link
Contributor

What this PR does / why we need it:

This patch reduces the packages we want coverage
for to pkg/ and internal/ (where all our code lives
now minus scripts and some build tools) and turns
on unit tests during the integration test runs to
capture more coverage data.

This patch reduces the packages we want coverage
for to pkg/ and internal/ (where all our code lives
now minus scripts and some build tools) and turns
on unit tests during the integration test runs to
capture more coverage data.
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #1611 (e8b7247) into next (0a503e5) will increase coverage by 16.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             next    #1611       +/-   ##
===========================================
+ Coverage   46.13%   62.63%   +16.49%     
===========================================
  Files          71       82       +11     
  Lines        6745     7180      +435     
===========================================
+ Hits         3112     4497     +1385     
+ Misses       3262     2358      -904     
+ Partials      371      325       -46     
Flag Coverage Δ
integration-test 62.63% <ø> (+16.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/ctrlutils/utils.go 93.75% <0.00%> (-2.09%) ⬇️
...et/typed/configuration/v1/fake/fake_kongingress.go 0.00% <0.00%> (ø)
...t/typed/configuration/v1/fake/fake_kongconsumer.go 0.00% <0.00%> (ø)
internal/cmd/main.go 0.00% <0.00%> (ø)
...configuration/v1/fake/fake_configuration_client.go 0.00% <0.00%> (ø)
...set/typed/configuration/v1/fake/fake_kongplugin.go 0.00% <0.00%> (ø)
...guration/v1beta1/fake/fake_configuration_client.go 0.00% <0.00%> (ø)
pkg/clientset/fake/clientset_generated.go 0.00% <0.00%> (ø)
...yped/configuration/v1beta1/fake/fake_tcpingress.go 0.00% <0.00%> (ø)
pkg/clientset/fake/register.go 100.00% <0.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a503e5...e8b7247. Read the comment docs.

@shaneutt shaneutt marked this pull request as ready for review July 30, 2021 13:37
@shaneutt shaneutt requested a review from a team as a code owner July 30, 2021 13:37
Copy link
Contributor

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't like the idea of running unit tests under the "integration tests" target, but I won't block this change if this helps with more accurate codecov 👍

@shaneutt shaneutt merged commit f56d00e into next Jul 30, 2021
@shaneutt shaneutt deleted the coverage-help branch July 30, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants