Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase the default for proxy requests #1610

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Jul 30, 2021

What this PR does / why we need it:

Increases the default proxy timeout based on experiences in GKE (which was failing).

Which issue this PR fixes

Adds fixes that supports #1095
Supports the analysis found in #1519

PR Readiness Checklist:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@shaneutt shaneutt added bug Something isn't working priority/high labels Jul 30, 2021
@shaneutt shaneutt self-assigned this Jul 30, 2021
@shaneutt shaneutt marked this pull request as ready for review July 30, 2021 13:07
@shaneutt shaneutt requested a review from a team as a code owner July 30, 2021 13:07
@Kong Kong deleted a comment from codecov bot Jul 30, 2021
Copy link
Contributor

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use some retry library instead of implementing retries ourselves? The second best thing to do is unit test the retry mechanism implemented in this PR but I think it would not be good use of our time.

@Kong Kong deleted a comment from codecov bot Jul 30, 2021
@shaneutt
Copy link
Contributor Author

Can we use some retry library instead of implementing retries ourselves? The second best thing to do is unit test the retry mechanism implemented in this PR but I think it would not be good use of our time.

Given that there's any contention I've opted to remove the retry mechanism from this PR in favor of focusing on the better default so we can get this fix quicker.

@Kong Kong deleted a comment from codecov bot Jul 30, 2021
@Kong Kong deleted a comment from codecov bot Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #1610 (6a3c65c) into next (f56d00e) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1610      +/-   ##
==========================================
+ Coverage   62.35%   62.56%   +0.20%     
==========================================
  Files          82       82              
  Lines        7180     7180              
==========================================
+ Hits         4477     4492      +15     
+ Misses       2372     2361      -11     
+ Partials      331      327       -4     
Flag Coverage Δ
integration-test 62.56% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/manager/config.go 92.50% <100.00%> (ø)
internal/proxy/clientgo_cached_proxy_resolver.go 82.11% <0.00%> (+1.32%) ⬆️
...trollers/configuration/zz_generated_controllers.go 34.63% <0.00%> (+2.03%) ⬆️
internal/ctrlutils/utils.go 95.83% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f56d00e...6a3c65c. Read the comment docs.

Copy link
Contributor

@ccfishk ccfishk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@shaneutt shaneutt merged commit 6042cfd into next Jul 30, 2021
@shaneutt shaneutt deleted the fix-prx-req-timeouts branch July 30, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants