Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core) smarter ngx.ctx.KONG_* timers #756

Merged
merged 1 commit into from
Dec 2, 2015
Merged

fix(core) smarter ngx.ctx.KONG_* timers #756

merged 1 commit into from
Dec 2, 2015

Conversation

thibaultcha
Copy link
Member

  • those timers are now automatically in milliseconds precision
  • don't use $upstream_response_time anymore since we need more
    granularity. $upstream_response_time cumulates both the waiting time
    and the receiving time, but we need to distinguish both in our logging
    plugins.
  • fix the ALF serializer which was still using old timers from before
    the core refactoring.

@thibaultcha thibaultcha added the pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release) label Dec 2, 2015
- those timers are now automatically in milliseconds precision
- don't use $upstream_response_time anymore since we need more
  granularity. $upstream_response_time cumulates both the waiting time
  and the receiving time, but we need to distinguish both in our logging
  plugins.
- fix the ALF serializer which was still using old timers from before
  the core refactoring.
thibaultcha added a commit that referenced this pull request Dec 2, 2015
fix(core) smarter ngx.ctx.KONG_* timers
@thibaultcha thibaultcha merged commit 91082bb into next Dec 2, 2015
@thibaultcha thibaultcha deleted the fix/timers branch December 2, 2015 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant