fix(proxy) prevent misinterpretation of '%' character in proxied URL encoding #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we cannot at the same time encode correctly query parameters that were properly unescaped before and those which aren't because in this case we cannot predict if the `%` character was part of the percent-encoding or just a character (e.g. "foo=%bar%") Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
thibaultcha
force-pushed
the
fix/url-double-percent-encoding
branch
from
ed6f7ea to
b4f81fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a patch that includes #1998 as well as a new integration test suite to ensure percent-encoding behavior of proxied URLs. The expected behavior is asserted in there as a source of truth.
Full changelog
Issues resolved
Fix #1975
Ensure #749 behavior
Ensure #688 behavior
Ensure #1480 behavior
Replaces #1998