[config] put cache in the DAO config.
#162
Conversation
thibaultcha
changed the title
cache in the DAO config.cache in the DAO config.
|
@thefosk Please thoughts, this makes the config less confusing for users I believe, as documented in: Kong/docs.konghq.com#45 |
|
I don't mind renaming it to |
|
Like explained, you might want to give a different cache value for cassandra than for sqlite. |
|
I still think caching should be DAO agnostic, until it will be removed when #15 is fully implemented. The only reason why the cache should be different for different DAOs is if there are some performance issues when setting different expirations times, which is not going to be the case (and we shouldn't support any datastore where this might be a case). Moreover the cache expiration is not related to the datastore but related to the a shared dictionary inside nginx, items don't expire from the datastore but from a shared dictionary. Putting the cache properties inside the datastore properties makes it seem like it's a cache that's somehow related to the datastore items/tables (like https://dev.mysql.com/doc/refman/5.1/en/query-cache.html). |
thibaultcha
force-pushed
the
configuration
branch
2 times, most recently
from
81256c8 to
cb0cfad
Compare
|
@thefosk updated |
|
It seems like now it's in two places, you forgot to delete the conf entry in the datastore settings. |
thibaultcha
force-pushed
the
configuration
branch
from
cb0cfad to
7cb63a2
Compare
|
Oops yes, fixed. Waiting for tests and I'll merge. |
[config] put `cache` in the DAO config.
[config] put `cache` in the DAO config.
### Summary #### libyaml 0.2.2 release - #95 -- build: do not install config.h - #97 -- appveyor.yml: fix Release build - #103 -- Remove unused code in yaml_document_delete - #104 -- Allow colons in plain scalars inside flow collections - #109 -- Fix comparison in tests/run-emitter.c - #117 -- Fix typo error - #119 -- The closing single quote needs to be indented... - #121 -- fix token name typos in comments - #122 -- Revert removing of open_ended after top level plain scalar - #125 -- Cherry-picks from PR 27 - #135 -- Windows/C89 compatibility - #136 -- allow override of Windows static lib name #### libyaml 0.2.3 release - #130 Fixed typo. - #144 Fix typo in comment - #140 Use pointer to const for strings that aren't/shouldn't be modified - #128 Squash a couple of warnings in example-deconstructor-alt - #151 Fix spelling for error message - #161 Make appveyor config be a hidden file - #159 Add CHANGES file - #160 Always output document end before directive (YAML 1.2 compatibility) - #162 Output document end marker after open ended scalars - #157 change cmake target name from libOFF.a to libyaml.a - #155 include/yaml.h: fix comments - #169 Fixed missing token in example - #127 Avoid recursion in the document loader. - #172 Support %YAML 1.2 directives - #66 Change dllexport controlling macro to use _WIN32
This makes it clearer for users that we are here talking about the cache
of the database entities, and not of any API added to Kong. It also
merges properties that are very linked together. In the case of another
database, one might want to have a bigger, or smaller caching value.