feat: lower Import UX friction by jackkav · Pull Request #9643 · Kong/insomnia

jackkav · 2026-02-06T09:43:43Z

Motivation: reduce friction to import collections and single requests and add flexibility to import location.
Goal: make curl a reasonable way to deeplink into the app allowing them to be added separately or in a collection

TODO

future work

use curlconverter in order to get more standard fallbacks and errors from bad inputs.

closes INS-1966

Copilot

Pull request overview

This PR improves the import UX (notably cURL) by adding source/origin context, immediate cURL validation feedback, and a project/collection selection flow, while also refactoring the cURL importer and aligning importer authentication typing with the main request model.

Changes:

Update Import modal UI (warning banner, larger cURL input, inline validation messaging, show origin link, allow selecting a target project/collection).
Refactor the cURL importer (better structure, bearer/basic auth parsing changes) and update tests/snapshots accordingly.
Align importer authentication typing with RequestAuthentication used by request models.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
packages/insomnia/src/ui/components/modals/import-modal/import-modal.tsx	Import modal UX updates (cURL textarea + validation, origin display, project/collection selectors)
packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.debug.request.new.tsx	Safer optional chaining for cookie counting
packages/insomnia/src/root.tsx	Propagate `origin` through deep-link import params
packages/insomnia/src/main/importers/importers/openapi-3.ts	Remove old `Authentication` type usage and rely on updated typing
packages/insomnia/src/main/importers/importers/curl.ts	Refactor cURL parsing/building; add bearer/basic auth extraction changes
packages/insomnia/src/main/importers/importers/curl.test.ts	Rewrite/condense cURL tests for refactored importer
packages/insomnia/src/main/importers/importers/snapshots/index.test.ts.snap	Snapshot update for auth shape (basic includes `type`)
packages/insomnia/src/main/importers/entities.ts	Replace custom `Authentication` with `RequestAuthentication
packages/insomnia/src/common/import.ts	Rename default imported workspace label to “Imported Collection”

Comments suppressed due to low confidence (1)

packages/insomnia/src/ui/components/modals/import-modal/import-modal.tsx:503

ImportResourcesForm's onImport prop signature was changed to include selectedProjectId, but the call sites still pass only selectedWorkspaceId (e.g. the Import button). This will shift arguments so the selected workspace id is treated as the project id, leading to imports targeting the wrong project/workspace. Update the handler plumbing so the Import button passes (overrideBaseEnvironmentData, selectedProjectId, selectedWorkspaceId) and the parent ImportModal uses selectedProjectId when submitting the import action.

}: {
  scanResults: ScanResult[];
  errors?: string[];
  onImport: (overrideBaseEnvironmentData: boolean, selectedProjectId?: string, selectedWorkspaceId?: string) => void;
  disabled: boolean;
  loading: boolean;
  isImportingBaseEnvironmentToWorkspace: boolean;
}) => {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T14:12:12Z

packages/insomnia/src/main/importers/importers/curl.ts

+const extractHeaders = (pairsByName: PairsByName) => {
+  return [...((pairsByName.header as string[] | undefined) || []), ...((pairsByName.H as string[] | undefined) || [])]
+    .filter(header => {
+      const [name, value] = header.split(/:(.*)$/);
+      return isBearerAuth(name, value) === false;
+    })


extractHeaders filters out bearer auth headers by splitting on : and calling isBearerAuth(name, value), but value can be undefined for malformed headers (no colon). This will throw before the later if (!value) handling. Ensure isBearerAuth handles missing values or default value to an empty string before calling it.

Copilot · 2026-02-12T14:12:13Z

packages/insomnia/src/main/importers/importers/curl.test.ts


-import type { Parameter } from '../entities';
-import { convert } from './curl';
+import { convert, name } from './curl';


Unused import: name is imported from ./curl but never referenced in this test file. This will fail lint/typecheck in many setups; remove it or use it in an assertion.

Suggested change

import { convert, name } from './curl';

import { convert } from './curl';

Copilot · 2026-02-12T14:12:13Z

packages/insomnia/src/ui/components/modals/import-modal/import-modal.tsx

+  const validateCurl = async (isMounted: boolean, value: string) => {
+    if (!value) {
+      isMounted && setMessage('Invalid cURL request');
+      return;
+    }
+    try {
+      const { data } = await window.main.parseImport(
+        {
+          contentStr: value,
+        },
+        {
+          importerId: 'curl',
+        },
+      );
+      const { resources } = data;
+      const importedRequest = resources[0];
+      isMounted &&
+        setMessage(
+          importedRequest.url
+            ? `Detected ${importedRequest.method} request to ${importedRequest.url}`
+            : 'Invalid cURL request',
+        );
+    } catch (error) {
+      console.log('[importer] error', error);

+      isMounted &&
+        setMessage(
+          error.message.includes('No importers found for file')
+            ? 'Invalid cURL request'
+            : error.message.replace("Error invoking remote method 'parseImport': Error: ", ''),
+        );
+    }
+  };
+  useEffect(() => {
+    let isMounted = true;
+
+    validateCurl(isMounted, from?.type === 'curl' && from.defaultValue ? from.defaultValue : '');
+    return () => {
+      isMounted = false;
+    };
+  }, [from]);


The isMounted guard in validateCurl doesn't work as intended: you're passing a boolean value into the async function, so setting isMounted = false in the cleanup won't affect an in-flight validation (it captured true). This can still call setMessage after unmount. Use a mutable ref (e.g. useRef(true)) or close over the isMounted variable directly (don’t pass it as a parameter), or use an AbortController/sequence id to ignore stale results.

Copilot · 2026-02-12T14:12:14Z

packages/insomnia/src/ui/components/modals/import-modal/import-modal.tsx

+      const { resources } = data;
+      const importedRequest = resources[0];
+      isMounted &&
+        setMessage(
+          importedRequest.url
+            ? `Detected ${importedRequest.method} request to ${importedRequest.url}`
+            : 'Invalid cURL request',
+        );


resources[0] is used without checking resources.length. If parseImport returns an empty resources array for invalid input, importedRequest will be undefined and importedRequest.url will throw. Guard against an empty result before reading url/method and set an appropriate message.

Copilot · 2026-02-12T14:12:14Z

packages/insomnia/src/ui/components/modals/import-modal/import-modal.tsx

+      isMounted &&
+        setMessage(
+          error.message.includes('No importers found for file')
+            ? 'Invalid cURL request'
+            : error.message.replace("Error invoking remote method 'parseImport': Error: ", ''),
+        );


In the catch block, error is unknown and may not have a .message property. Accessing error.message can throw and mask the original failure. Narrow with error instanceof Error (or safely stringify) before reading message, and avoid relying on exact remote-method prefix strings for parsing.

Suggested change

isMounted &&

setMessage(

error.message.includes('No importers found for file')

? 'Invalid cURL request'

: error.message.replace("Error invoking remote method 'parseImport': Error: ", ''),

);

const rawMessage =

error instanceof Error

? error.message

: String(error);

const cleanedMessage = rawMessage.replace(

"Error invoking remote method 'parseImport': Error: ",

'',

);

const finalMessage = rawMessage.includes('No importers found for file')

? 'Invalid cURL request'

: cleanedMessage;

isMounted && setMessage(finalMessage);

Copilot · 2026-02-12T14:12:14Z

packages/insomnia/src/ui/components/modals/import-modal/import-modal.tsx

+        {from?.type === 'curl' && from.origin && (
+          <div className="flex w-full justify-start py-1">
+            <CurlIcon />
+            cURL from{' '}
+            <Link className="px-2 font-bold underline" href={from.origin}>
+              {' '}
+              {from.origin}{' '}
+            </Link>{' '}
+            ⚠️
+          </div>


from.origin is untrusted input (comes from URL params) and is being placed directly into an anchor href via react-aria-components Link. This can enable javascript:/unexpected schemes in a clickable link. Prefer the app’s ~/ui/components/base/link (which routes through window.main.openInBrowser) and/or validate/allowlist schemes (http/https) before rendering/clicking.

packages/insomnia/src/main/importers/importers/curl.ts

jackkav changed the title ~~Fix/import-modal-feedback~~ Import UX improvements Feb 6, 2026

jackkav force-pushed the fix/import-modal-feedback branch 2 times, most recently from e72b619 to e4a0e2a Compare February 12, 2026 10:16

jackkav marked this pull request as ready for review February 12, 2026 14:06

jackkav requested review from a team, ZxBing0066, Copilot and gatzjames February 12, 2026 14:06

Copilot started reviewing on behalf of jackkav February 12, 2026 14:07 View session

jackkav changed the title ~~Import UX improvements~~ feat: lower Import UX friction Feb 12, 2026

Copilot AI reviewed Feb 12, 2026

View reviewed changes

jackkav force-pushed the fix/import-modal-feedback branch from 7e4b656 to e80762a Compare February 13, 2026 11:28

ryan-willis approved these changes Feb 13, 2026

View reviewed changes

jackkav added 17 commits February 16, 2026 09:07

text area curl input

dcb72b9

add origin and warning

d933b1e

use Collection naming

e7bd50e

fix overflowing long import ui

c70b33a

refactor curl and tests

1047781

fix json input

284d357

inline validation

24c2dd3

improve validation message

fe1f403

add bearer support

0a9d7f9

auto validate on deeplink

2e99f0e

layout

bf09c60

fix types

6536540

remove usemount

817739a

handle unmounting

ab9969e

add project select

2450d05

update snapshot

e48741a

disable scan without valid input

d6bc53a

jackkav added 5 commits February 16, 2026 09:07

tolerate undefined headers

6dc5d0f

set overflow

2626e4a

make useEffect safe

6dd7df7

prevent fetch of empty project

69634ff

copilot feedback

2bc6ea4

jackkav force-pushed the fix/import-modal-feedback branch from e80762a to 2bc6ea4 Compare February 16, 2026 08:07

jackkav enabled auto-merge (squash) February 16, 2026 08:12

jackkav merged commit 5b6c59d into Kong:develop Feb 16, 2026
10 checks passed

jackkav deleted the fix/import-modal-feedback branch February 16, 2026 08:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: lower Import UX friction#9643

feat: lower Import UX friction#9643
jackkav merged 22 commits intoKong:developfrom
jackkav:fix/import-modal-feedback

jackkav commented Feb 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	import { convert, name } from './curl';
	import { convert } from './curl';

-      isMounted &&
-        setMessage(
-          error.message.includes('No importers found for file')
-            ? 'Invalid cURL request'
-            : error.message.replace("Error invoking remote method 'parseImport': Error: ", ''),
-        );
+      const rawMessage =
+        error instanceof Error
+          ? error.message
+          : String(error);
+      const cleanedMessage = rawMessage.replace(
+        "Error invoking remote method 'parseImport': Error: ",
+        '',
+      );
+      const finalMessage = rawMessage.includes('No importers found for file')
+        ? 'Invalid cURL request'
+        : cleanedMessage;
+      isMounted && setMessage(finalMessage);

Conversation

jackkav commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jackkav commented Feb 6, 2026 •

edited

Loading