Merged
Conversation
✨ Circular References ReportGenerated at: 2026-02-04T17:29:52.583Z Summary
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds/extends analytics tracking for Insomnia desktop and the inso CLI, including disabling desktop analytics during Playwright smoke tests and refactoring some shared CLI utilities to avoid circular dependencies.
Changes:
- Added Playwright gating for desktop Segment event + page view tracking.
- Introduced Segment analytics tracking for
insoCLI commands (run test/collection, lint spec, export spec, script). - Extended
insoDB loading types to include Settings, and refactored CLI path helpers into a shared util module.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/insomnia/src/main/analytics.ts | Skips Segment tracking during Playwright runs; updates Segment event enum placement. |
| packages/insomnia-smoke-test/fixtures/inso-nedb/insomnia.CloudCredential.db | Fixture DB update used by smoke tests. |
| packages/insomnia-smoke-test/fixtures/inso-nedb/insomnia.CaCertificate.db | Fixture DB update used by smoke tests. |
| packages/insomnia-inso/src/util.ts | Extracted app data dir + product name helpers from CLI. |
| packages/insomnia-inso/src/db/index.ts | Adds Settings collection to the inso DB shape. |
| packages/insomnia-inso/src/cli.ts | Emits/flushes new CLI analytics events around command execution outcomes. |
| packages/insomnia-inso/src/analytics.ts | New Segment analytics client + settings/deviceId resolution for CLI tracking. |
| packages/insomnia-inso/package.json | Adds Segment analytics dependency for inso. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b4fa9cc to
7cbc386
Compare
ZxBing0066
reviewed
Feb 3, 2026
e5fb5c0 to
af9c328
Compare
ZxBing0066
reviewed
Feb 4, 2026
af9c328 to
dd38ed7
Compare
ZxBing0066
approved these changes
Feb 5, 2026
Member
ZxBing0066
left a comment
There was a problem hiding this comment.
👍 LGTM.
Please hold on merge until 12.3.1 GA.
pavkout
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.