Skip to content

fix: sentry sourcemap - [INS-1255]#9249

Merged
jackkav merged 3 commits intodevelopfrom
fix/sentry-source-map
Oct 16, 2025
Merged

fix: sentry sourcemap - [INS-1255]#9249
jackkav merged 3 commits intodevelopfrom
fix/sentry-source-map

Conversation

@CurryYangxx
Copy link
Member

@CurryYangxx CurryYangxx commented Oct 11, 2025

Upload sourcemaps to Sentry

  • pack all JS resources into the sourcemap artifact
  • correct the artifact name for Sentry sourcemaps upload

@CurryYangxx CurryYangxx marked this pull request as draft October 11, 2025 08:58
@CurryYangxx CurryYangxx force-pushed the fix/sentry-source-map branch from bf02f24 to b7adf0e Compare October 11, 2025 09:46
@CurryYangxx CurryYangxx changed the title fix: sentry sourcemap fix: sentry sourcemap - [INS-1255] Oct 13, 2025
@CurryYangxx CurryYangxx force-pushed the fix/sentry-source-map branch from 215fc9a to 74e12a2 Compare October 14, 2025 09:59
@CurryYangxx CurryYangxx marked this pull request as ready for review October 14, 2025 10:02
@CurryYangxx CurryYangxx requested a review from a team October 14, 2025 10:02
ZxBing0066
ZxBing0066 previously approved these changes Oct 14, 2025
packages/insomnia/build/*.js
packages/insomnia/build/*.map
packages/insomnia/build/client/assets/*.js
packages/insomnia/build/client/assets/*.map
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use packages/insomnia/build/**/*.js to avoid adding new paths in the future?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we don't need to care about the subpath if we change to packages/insomnia/build/**/*.js

jackkav
jackkav previously approved these changes Oct 14, 2025
@CurryYangxx CurryYangxx dismissed stale reviews from jackkav and ZxBing0066 via b6c895b October 15, 2025 08:48
@jackkav jackkav force-pushed the fix/sentry-source-map branch from b6c895b to 10bb181 Compare October 16, 2025 13:26
@jackkav jackkav merged commit bec951e into develop Oct 16, 2025
13 checks passed
@jackkav jackkav deleted the fix/sentry-source-map branch October 16, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants