chore: reduce vite external deps#9212
Merged
jackkav merged 2 commits intoKong:developfrom Oct 16, 2025
Merged
Conversation
75cf787 to
fb390b7
Compare
fb390b7 to
f7b8695
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: remove tech debt
This PR aims to reduce the giant allowlist we were using to chose what not to include in the bundle. Specifically only the vite renderer bundle.
Note:
turns out the tests all pass with only 3 of the 30 or so external deps. This also highlights code paths which could be extracted to main.
potenitalwork