-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add a log on the parentId set null #6876
chore: add a log on the parentId set null #6876
Conversation
@gatzjames this was a tricky to find the root cause and fix. I currently added a temporary hack around in the database module that is used in both inso-cli and insomnia desktop client. In my opinion, this is not a great architectural choice made. Maybe I am missing out something here, but,
This CLI tool and the electron app are so coupled in the current state of the Insomnia. I think we should decouple this as soon as possible, ESPECIALLY, if Insomnia product wants to revamp the testing feature in my opinion. |
I added a HACK to bypass this. Please go ahead if you find a better fix on this. |
We are adding the sentry log to measure the data loss issue under the pressure, but ideally we should log the case happening here and fire them in batch outside of the database context. |
nedb is required by inso cli because running requests and tests requires reading context from the db, inso also allows you to point it at different db folders. we have yet to find a good high level solution to this, i would advise leaving some breadcrumbs for someone to undo your hack incase it blocks some upgrade or feature in the future |
Not sure if there is more thing to give as breadcrumb. Future contributors should be able to learn the context in this PR description and threads with the INS ticket information as well. They can remove the following functions introduced by this PR: assertModelWithParentId(), registerCaptureException() |
* chore: add a log on the parentId set null * add more logs * fix: capture exception instead * fix: add a hack * chore: add comments * fix: ensure process error from sentry * rename fn * docs: add a comment * fix: sentry exception catcher load --------- Co-authored-by: gatzjames <jamesgatzos@gmail.com>
Let's measure how many users are impacted by this bug and experiencing the data linking issue.
Closes INS-3301