chore(tests): disable KIC admission webhook for TestKongPluginInstallationEssentials
#656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
force-pushed
the
disable-webhook
branch
from
1d6d572
to
286c7e7
Compare
programmer04
force-pushed
the
disable-webhook
branch
from
286c7e7
to
7ac5a42
Compare
pmalek
approved these changes
Sep 26, 2024
programmer04
force-pushed
the
disable-webhook
branch
from
a9e9a44
to
f69a82d
Compare
pmalek
approved these changes
Sep 26, 2024
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
pmalek
force-pushed
the
disable-webhook
branch
from
f69a82d
to
aa3e7a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Flakiness of
TestKongPluginInstallationEssentialshas been observed, e.g. here and here. It's due to how our webhook in KIC tries to reject as soon as possible that leads to requirement of strict ordering.Which issue this PR fixes
Followup for #380
Special notes for your reviewer:
Remediation from the original PR with disabling a webhook was incorrect because it took into account only the webhook of KGO which in this case is irrelevant.