Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for ensureDeploymentForControlPlane similarly as it's done for DataPlane #180

Open
1 task
pmalek opened this issue May 22, 2023 · 0 comments
Open
1 task

Add tests for ensureDeploymentForControlPlane similarly as it's done for DataPlane #180

pmalek opened this issue May 22, 2023 · 0 comments
Labels
area/maintenance area/tests good first issue Good for newcomers migrated-from-archive Issues migrated from the archived KGO repository

Comments

@pmalek
Copy link
Member

pmalek commented May 22, 2023 •
edited
Loading

Problem statement

Currently we have tests for ensuring that the DataPlane Deployment is in place but we don't have such tests for ControlPlane (for ensureDeploymentForControlPlane specifically). This issue aims to track the effort of adding such tests for the ControlPlane.

Acceptance criteria

  • Tests for ensuring that ControlPlane Deployment is in place are added.
@pmalek pmalek added the migrated-from-archive Issues migrated from the archived KGO repository label Apr 19, 2024
@czeslavo czeslavo transferred this issue from another repository Apr 22, 2024
@czeslavo czeslavo transferred this issue from another repository Apr 23, 2024
pmalek pushed a commit that referenced this issue Jun 29, 2024
@mlavacca
fix: predicates for detecting whether the deployment is active (#180)
b9bae12 
fix: HasActiveDeployment predicates

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/maintenance area/tests good first issue Good for newcomers migrated-from-archive Issues migrated from the archived KGO repository
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pmalek @shaneutt