-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(kic) add Gateway API concepts #4230
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
fde46f9
to
d267cf7
Compare
Is this ready to be reviewed? |
17aa36f
to
baac9fc
Compare
@Guaris should be. We may get a few more comments from the rest of the Kubernetes team on tech stuff, but those hopefully don't result in huge changes. Not urgent, so if you want to wait a few days for any of those to trickle in before giving it a final pass that's fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM here, so removed my change requests. But did not directly approve, to wait for others' reviews
ignore this -- dupelicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM here, so removed my change requests. But did not directly approve, to wait for others' reviews.
baac9fc
to
15efc5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking to get the whitespaces resolved
15efc5f
to
4ea02eb
Compare
Summary
Adds a new Gateway API page under the KIC Concepts section. This covers two alpha limitations where Kong's implementation differs from a hypothetical standard Gateway API implementation:
Update the Gateway API guide with links to the new concepts page.
Update the Gateway API guide to include an example of a user-provided certificate.
Reason
Fix #4054
Fix #4229
Testing
Awaiting preview.