Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kong-ee) migrate the private kong-ee repository to here #336

Merged
merged 14 commits into from
Feb 14, 2020

Conversation

hutchic
Copy link
Contributor

@hutchic hutchic commented Feb 13, 2020

The docker-kong-ee git repository is mostly the same as this one. This PR moves us towards merging them while keeping the flexibility of diverging when necessary.

Tested the changes to update.sh by using it to update CE from 2.0.0 to 2.0.1 as demonstrated in this commit 04ee359

@hutchic hutchic changed the base branch from feat/kong-ee to master February 13, 2020 21:45
@hutchic hutchic force-pushed the chore/separate-build-scripts branch from 0659693 to 4667fad Compare February 13, 2020 21:55
@hutchic hutchic force-pushed the chore/separate-build-scripts branch from 4667fad to f8c849a Compare February 13, 2020 21:55
@hutchic hutchic requested review from kidd, gszr and a user February 14, 2020 02:13
Copy link
Contributor

@kidd kidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codewise looks good

but I'm a bit worried on how will we test the future changes. Also, update.sh only works for ce for now.

@hutchic
Copy link
Contributor Author

hutchic commented Feb 14, 2020

I've been toying with ways to test EE in public repositories in a safe / secure and sane way.

In the spirit of incremental improvement I'm going to merge this one shortly but there's no rush to cut Kong Enterprise over to using it right away

@hutchic hutchic changed the title Chore/separate build scripts chore(kong-ee) migrate the private kong-ee repository to here Feb 14, 2020
@hutchic hutchic merged commit d2d7074 into master Feb 14, 2020
@hutchic hutchic deleted the chore/separate-build-scripts branch February 14, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants