Repository navigation
fix: preserve CA certificate references when sanitizing - #2262
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sanitizing a dump preserves CA certificate IDs but currently hashes references to those IDs in Services and plugin configuration. This leaves the sanitized configuration pointing at certificates that do not exist and can prevent it from being imported.
Preserve
Service.CACertificatesand pluginca_certificatesreferences, consistent with the existing CA certificate ID exemption. The regression exercises both reference locations and checks that unrelated service/plugin values and certificate contents are still sanitized.Fixes #1830.
Validation:
go test -race -count=1 ./...passed.go test -race -count=1 ./...passed.git diff --checkpassed.External Kong/Konnect integration tests requiring services or credentials were not run.
Prepared with Codex assistance.