Repository navigation
fix: identify unnamed routes by paths/methods/hosts/service in sync errors - #2249
Draft
equistar22 wants to merge 1 commit into
Draft
equistar22 wants to merge 1 commit into
equistar22 wants to merge 1 commit into
Conversation
…rrors Bumps go-database-reconciler to a pre-release commit containing the Route.Console() fix (Kong/go-database-reconciler#531) so sync/diff messages for unnamed routes no longer fall back to a bare Kong-assigned ID that doesn't exist in source config. NOTE: pinned to a pseudo-version at the reconciler PR's commit; needs to be re-pointed at a real tagged release once #531 merges and one is cut.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
=======================================
Coverage 36.02% 36.02%
=======================================
Files 82 82
Lines 7844 7844
=======================================
Hits 2826 2826
Misses 4750 4750
Partials 268 268 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a large
deck sync, route errors were reported only by the Kong-assigned ID (a UUID), since unnamed routes fell back to that ID for their console/error identifier — a value that doesn't exist in source config unless it was dumped with--with-id, making failures impossible to correlate back to the offending route.Full changelog
Issues resolved
GDR PR: Kong/go-database-reconciler#531
Testing
go test ./cmd/...and the full non-integration suite)TestSyncErrorMessage_UnnamedRoutefails against the currently releasedv1.42.4(reproduces the bug) and passes against the fix