Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress: enforce expressions router flavor when using KIC v3.0+ #937

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Nov 9, 2023

What this PR does / why we need it:

Use an obscure .Subcharts variable to get subcharts values and based on that enforce the expressions router flavor in Kong Gateway when KIC v3.0+ is used

@czeslavo
Copy link
Contributor

czeslavo commented Nov 9, 2023

Nothing really important, but I tested both Subcharts.gateway.Values and .Values.gateway and they give the same data (validation fails as expected). I have no idea which way is the good way as I couldn't find documentation for any. 😬

--- a/charts/ingress/templates/_helpers.tpl
+++ b/charts/ingress/templates/_helpers.tpl
@@ -1,6 +1,6 @@
 {{- define "ingressController.enforceGatewayRouterFlavorFor3_0AndUp" -}}
-{{ $gatewayValues := .Subcharts.gateway.Values }}
-{{ $controllerValues := .Subcharts.controller.Values }}
+{{ $gatewayValues := .Values.gateway }}
+{{ $controllerValues := .Values.controller }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants