Skip to content

feat(deployment) add template rendering to initContainers#826

Open
jeroen-vankelecom wants to merge 4 commits into
Kong:mainfrom
jeroen-vankelecom:template-init-containers
Open

feat(deployment) add template rendering to initContainers#826
jeroen-vankelecom wants to merge 4 commits into
Kong:mainfrom
jeroen-vankelecom:template-init-containers

Conversation

@jeroen-vankelecom

Copy link
Copy Markdown

What this PR does / why we need it:

Allow users to pass helm templates (e.g. for the image name) when definining additional initContainers

Which issue this PR fixes

Special notes for your reviewer:

None

Checklist

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@jeroen-vankelecom jeroen-vankelecom requested a review from a team as a code owner June 26, 2023 15:57
@CLAassistant

CLAassistant commented Jun 26, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@pmalek pmalek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jeroen-vankelecom 👋

This change looks good, are you still interested in contributing this? If so, then please rebase on most recent main tip and please add an exemplar values.yaml in https://github.com/Kong/charts/tree/main/charts/kong/ci so that the test harness can test this on CI and we can see an actual usage of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow templated values in initContainers field

3 participants