Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(konnect): require gw discovery, rename gw discovery and release 2.17.0-rc.1 #759

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Feb 23, 2023

What this PR does / why we need it:

Requires Gateway discovery to be enabled when Konnect sync is enabled. As a result, splits the example values for Konnect into the already existing minimal-kong-gd-gateway.yaml and a new minimal-kong-gd-controller-konnect.yaml. Also renames the serviceDiscovery to gatewayDiscovery.

Which issue this PR fixes

Part of Kong/kubernetes-ingress-controller#3581 and #740.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@czeslavo czeslavo self-assigned this Feb 23, 2023
@czeslavo czeslavo marked this pull request as ready for review February 23, 2023 21:10
@czeslavo czeslavo requested a review from a team as a code owner February 23, 2023 21:10
@czeslavo czeslavo force-pushed the konnect-is-multi-gw branch 2 times, most recently from 6aaf36c to 14adac1 Compare February 24, 2023 12:04
@czeslavo czeslavo changed the title feat(konnect): require gateway discovery enabled + rename gw discovery feat(konnect): require gw discovery, rename gw discovery and release 2.17.0-rc.1 Feb 24, 2023
mflendrich
mflendrich previously approved these changes Feb 24, 2023
Copy link
Contributor

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go.

In search of renaming leftovers I have: eyeballed the diff, grepped the codebase for sd, service.discovery and servicediscovery - all in a case-insensitive way. Looks good.

charts/kong/README.md Outdated Show resolved Hide resolved
@czeslavo czeslavo enabled auto-merge (squash) February 24, 2023 16:13
@czeslavo czeslavo merged commit 2acaa03 into main Feb 24, 2023
@czeslavo czeslavo deleted the konnect-is-multi-gw branch February 24, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants