-
Notifications
You must be signed in to change notification settings - Fork 493
feat(kgo): add node selector to deployment #1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Apart from the minor nit please rebase on latest main
tip and resolve conflicts.
@@ -0,0 +1,16 @@ | |||
nodeSelector: | |||
karpenter.sh/nodepool: my-nodepool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work on our CI.
We run these values.yaml files against an actual kind cluster and this label is not set on its nodes. You can try using something generic that we should always see on nodes like kubernetes.io/os: linux
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the heads up, just committed the requested changes
4fad38f
to
e2d9674
Compare
Please run |
@vitoorgomes Just checking in, do you still want to contribute this change? |
hey @pmalek, sorry for the late response, the last couple of weeks have been rough I will rebase and run the make cmd and push it soon |
What this PR does / why we need it:
The idea is to add an option to specify the node on which the KGO controller should be scheduled. This feature can be helpful when clusters have dedicated nodes for specific use cases
Special notes for your reviewer:
I'm not sure if I forgot to run something locally, in any case, just let me know
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
main
branch.