[performance bug] Fix Sequence::clear() #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crydsch <crydsch@lph.zone>
Crydsch
force-pushed
the
fix_sequence_clear
branch
from
8cc614b
to
2a9f82a
Compare
|
Great fix, thank you! Woudl be great to add a unit test for this if possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I noticed a performance degradation over time
when repeatedly calling
Sequence::eval(..)orSequence::evalAsync(..).Both functions first clear the currently recorded operations by calling
Sequence::clear(),then record and actually evaluate the new operation.
The problem is -
Sequence::clear()never actually clears the operations.This leads to operations just adding up.
This PR simply adds the missing clear call.
I guess this was just an oversight...
I only noticed this problem only in a compute heavy, long running process.