Skip to content

Release 2.0.6 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

Release 2.0.6 #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f0e5af
Updated version and changed anddroid code.
prateek-singh-3212 May 6, 2025
5e63992
KMFirebase Update Added and Event library added
AbhijeetRanjan308 May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 2.0.6
### Android
- Update android dependency with applozic mitration code.
## 2.0.5
### iOS
- Added Business Hours feature.
Expand Down
4 changes: 2 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:4.1.3'
classpath 'com.android.tools.build:gradle:7.4.2' // Update this
}
}

Expand Down Expand Up @@ -39,5 +39,5 @@ android {

dependencies {
implementation fileTree(include: ['*.jar'], dir: 'libs')
api 'io.kommunicate.sdk:kommunicateui:2.13.3'
api 'io.kommunicate.sdk:kommunicateui:2.14.0'
}
7 changes: 7 additions & 0 deletions android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-all.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
15 changes: 8 additions & 7 deletions android/src/main/java/io/kommunicate/kommunicate_flutter_plugin/KmEventListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,27 @@
package io.kommunicate.kommunicate_flutter_plugin;

import com.applozic.mobicomkit.broadcast.AlEventManager;
import io.kommunicate.callbacks.KmPluginEventListener;
import com.applozic.mobicomkit.api.conversation.Message;
import io.flutter.plugin.common.MethodChannel;
import com.applozic.mobicommons.json.GsonUtils;
import io.kommunicate.commons.json.GsonUtils;
import io.kommunicate.devkit.api.conversation.Message;
import io.kommunicate.devkit.broadcast.EventManager;
import io.kommunicate.devkit.listners.KmConversationInfoListener;

import org.json.JSONObject;
import org.json.JSONException;
import com.applozic.mobicomkit.listners.KmConversationInfoListener;


public class KmEventListener implements KmPluginEventListener, KmConversationInfoListener {
private MethodChannel methodChannel;

public void register(MethodChannel methodChannel) {
this.methodChannel = methodChannel;
AlEventManager.getInstance().registerPluginEventListener(this);
AlEventManager.getInstance().registerConversationInfoListener(this);
EventManager.getInstance().registerPluginEventListener(this);
EventManager.getInstance().registerConversationInfoListener(this);
}

public void unregister() {
AlEventManager.getInstance().unregisterPluginEventListener();
EventManager.getInstance().unregisterPluginEventListener();
}
Comment on lines 23 to 25
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Incomplete Unregister Implementation
unregister() only unregisters the plugin event listener. To avoid listener leaks:

  1. Pass this to unregisterPluginEventListener(this) if required by the API.
  2. Also call unregisterConversationInfoListener(this).
 public void unregister() {
-    EventManager.getInstance().unregisterPluginEventListener();
+    EventManager.getInstance().unregisterPluginEventListener(this);
+    EventManager.getInstance().unregisterConversationInfoListener(this);
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
public void unregister() {
AlEventManager.getInstance().unregisterPluginEventListener();
EventManager.getInstance().unregisterPluginEventListener();
}
public void unregister() {
EventManager.getInstance().unregisterPluginEventListener(this);
EventManager.getInstance().unregisterConversationInfoListener(this);
}


@Override
Expand Down
34 changes: 15 additions & 19 deletions android/src/main/java/io/kommunicate/kommunicate_flutter_plugin/KmMethodHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,30 +21,26 @@
import io.kommunicate.callbacks.KMLogoutHandler;
import io.kommunicate.callbacks.KmCallback;
import io.kommunicate.callbacks.KmGetConversationInfoCallback;
import io.kommunicate.commons.json.GsonUtils;
import io.kommunicate.commons.people.channel.Channel;
import io.kommunicate.commons.people.contact.Contact;
import io.kommunicate.devkit.SettingsSharedPreference;
import io.kommunicate.devkit.api.account.register.RegistrationResponse;
import io.kommunicate.devkit.api.account.user.User;
import io.kommunicate.devkit.api.account.user.UserUpdateTask;
import io.kommunicate.devkit.api.conversation.MessageBuilder;
import io.kommunicate.devkit.api.conversation.database.MessageDatabaseService;
import io.kommunicate.devkit.channel.service.ChannelService;
import io.kommunicate.devkit.feed.ChannelFeedApiResponse;
import io.kommunicate.devkit.listners.ResultCallback;
import io.kommunicate.ui.conversation.fragment.MobiComConversationFragment;
import io.kommunicate.users.KMUser;
import io.kommunicate.KmConversationHelper;
import io.kommunicate.KmException;

import com.applozic.mobicomkit.api.account.user.User;
import com.applozic.mobicomkit.ApplozicClient;
import com.applozic.mobicomkit.api.account.user.AlUserUpdateTask;
import com.applozic.mobicomkit.api.conversation.database.MessageDatabaseService;
import com.applozic.mobicomkit.channel.service.ChannelService;
import com.applozic.mobicomkit.feed.ChannelFeedApiResponse;
import com.applozic.mobicomkit.listners.AlCallback;
import com.applozic.mobicommons.json.GsonUtils;
import com.applozic.mobicomkit.api.account.register.RegistrationResponse;
import com.applozic.mobicommons.people.channel.Channel;
import com.applozic.mobicommons.people.contact.Contact;
import com.applozic.mobicomkit.uiwidgets.conversation.fragment.MobiComConversationFragment;
import com.applozic.mobicomkit.api.conversation.AlTotalUnreadCountTask;

import io.kommunicate.preference.KmConversationInfoSetting;
import io.kommunicate.utils.KMAgentStatusHelper;

import com.applozic.mobicomkit.broadcast.AlEventManager;
import com.applozic.mobicomkit.api.conversation.MessageBuilder;

import java.util.HashMap;
import java.util.Map;

Expand Down Expand Up @@ -393,7 +389,7 @@ public void onFailure(Object error) {
if (KMUser.isLoggedIn(context)) {
JSONObject userObject = new JSONObject(call.arguments.toString());
KMUser kmUser = (KMUser) GsonUtils.getObjectFromJson(userObject.toString(), KMUser.class);
new AlUserUpdateTask(context, kmUser, new AlCallback() {
new UserUpdateTask(context, kmUser, new ResultCallback() {
@Override
public void onSuccess(Object message) {
result.success(SUCCESS);
Expand Down Expand Up @@ -477,7 +473,7 @@ public void onFailure(Object o) {
}
} else if (call.method.equals("hideChatListOnNotification")) {
try {
ApplozicClient.getInstance(context).hideChatListOnNotification();
SettingsSharedPreference.getInstance(context).hideChatListOnNotification();
result.success(SUCCESS);
} catch (Exception e) {
result.error(ERROR, e.toString(), null);
Expand Down
2 changes: 1 addition & 1 deletion example/android/app/src/main/java/io/pushnotification/KmFirebaseMessagingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
package io.pushnotification;

import com.applozic.mobicommons.commons.core.utils.Utils;
import com.google.firebase.messaging.FirebaseMessagingService;
import com.google.firebase.messaging.RemoteMessage;

import io.kommunicate.Kommunicate;
import io.kommunicate.commons.commons.core.utils.Utils;

public class KmFirebaseMessagingService extends FirebaseMessagingService {

Expand Down
2 changes: 1 addition & 1 deletion example/pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ packages:
path: ".."
relative: true
source: path
version: "2.0.5"
version: "2.0.6"
leak_tracker:
dependency: transitive
description:
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: kommunicate_flutter
description: Flexible, lightweight, and easily integrable Flutter SDK for Kommunicate AI chatbot & Live Chat.
version: 2.0.5
version: 2.0.6
homepage: https://kommunicate.io

environment:
Expand Down