-
Notifications
You must be signed in to change notification settings - Fork 23
Release v2.0.3 #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.0.3 #159
Conversation
WalkthroughThis update bumps the package version to 2.0.3 and adjusts several dependency versions across Android and iOS platforms. The changelog now reflects updates including Android migration to Coroutines, removal of deprecated async tasks and raw queries, and adding edge-to-edge support for Android 15. iOS modifications involve a code refactor, TableView updates, and the replacement of deprecated code and warnings. Additionally, a typing indicator for bot message delay was added, an Android manifest merge rule was altered, and the iOS app entry annotation was updated to modern Swift standards. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant Bot
User->>App: Send message
App->>Bot: Forward message
Bot-->>App: Initiate typing indicator (delay)
App->>User: Display typing indicator
Bot-->>App: Send response after delay
App->>User: Show bot response
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
1-10
: Fix typos in the changelog entries.There are a few typos in the changelog entries that should be corrected:
- Line 4: "Depricated" should be "Deprecated"
- Line 5: "querries" should be "queries"
- Line 10: "depricated" should be "deprecated"
Otherwise, the changelog entries accurately reflect the changes made in this release.
- Migration to Coroutines and removed Depricated Async Tasks for Android. + Migration to Coroutines and removed Deprecated Async Tasks for Android. - Remove Raw query querries usage for Android. + Remove Raw query queries usage for Android. - Updated depricated Code and resolved Warnings. + Updated deprecated Code and resolved Warnings.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
example/pubspec.lock
is excluded by!**/*.lock
📒 Files selected for processing (7)
CHANGELOG.md
(1 hunks)README.md
(1 hunks)android/build.gradle
(1 hunks)example/android/app/src/main/AndroidManifest.xml
(1 hunks)example/ios/Runner/AppDelegate.swift
(1 hunks)ios/kommunicate_flutter.podspec
(1 hunks)pubspec.yaml
(1 hunks)
🔇 Additional comments (6)
android/build.gradle (1)
42-42
: SDK version update correctly implements PR objectives for Android.The update to version 2.13.2 of the Kommunicate Android SDK incorporates the features mentioned in the PR objectives, including migration to Coroutines, removal of deprecated Async Tasks and raw queries, and edge-to-edge support for Android 15+.
example/ios/Runner/AppDelegate.swift (1)
4-4
: Modernized Swift annotation follows best practices.Updating from
@UIApplicationMain
to@main
aligns with modern Swift standards and helps resolve deprecated code warnings as mentioned in the PR objectives. This is part of the iOS code refactoring effort.pubspec.yaml (1)
3-3
: Version bump correctly implements the 2.0.3 release.The version update from 2.0.2 to 2.0.3 follows semantic versioning principles and properly reflects the culmination of all changes described in the PR objectives, including SDK updates for both platforms and various improvements.
README.md (1)
16-16
: Documentation correctly updated to reflect new version.The version reference update in the README ensures that documentation stays in sync with the actual package version, providing accurate installation instructions for users.
ios/kommunicate_flutter.podspec (1)
20-20
: Updated iOS SDK dependency to latest version.The dependency for the Kommunicate iOS SDK has been updated from '
> 7.2.7' to '> 7.2.8', which aligns with the version update mentioned in the PR objectives.example/android/app/src/main/AndroidManifest.xml (1)
40-41
:❓ Verification inconclusive
Verify impact of manifest merge rule change.
The
android:allowBackup="false"
attribute is still present, but it's no longer included in thetools:replace
directive. This means during the manifest merging process, if the Kommunicate Android SDK specifies a different value forallowBackup
, it might override this setting.Since
allowBackup
controls whether app data can be backed up, this change could potentially impact data security and backup behavior.
🏁 Script executed:
#!/bin/bash # Check if the Kommunicate SDK specifies an allowBackup attribute in its manifest # that might conflict with the app's setting # Search for allowBackup in any AndroidManifest.xml files in dependencies find . -path "*/build/intermediates/**/AndroidManifest.xml" -type f -exec grep -l "android:allowBackup" {} \; | xargs cat 2>/dev/null | grep "android:allowBackup" # Also check the raw SDK manifest if available find . -path "*/com/kommunicate/**/AndroidManifest.xml" -type f -exec grep -l "android:allowBackup" {} \; | xargs cat 2>/dev/null | grep "android:allowBackup"Length of output: 299
Manifest Merge Caution – Verify SDK Backup Settings
Our automated search did not detect any
android:allowBackup
attribute in the Kommunicate SDK or build-generated manifest fragments that might conflict with your explicit setting (android:allowBackup="false"
). This indicates that, as of now, the SDK does not override this attribute. However, since thetools:replace
directive now omitsandroid:allowBackup
, any future change in the SDK manifest supplying a different value could unintentionally override your setting.• Confirm that future versions of the Kommunicate SDK do not introduce an
allowBackup
attribute in their manifest.
• Manually verify the manifest merge output to ensure thatandroid:allowBackup="false"
is preserved across all build scenarios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Summary
Android
iOS
Summary by CodeRabbit
New Features
Chores