-
Notifications
You must be signed in to change notification settings - Fork 23
Release v1.9.8 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.9.8 #145
Conversation
WalkthroughThe pull request includes updates across several files to reflect the new version 1.9.8 of the Kommunicate Flutter plugin. The changelog has been modified to document a fix related to date and time response formats for iOS postback messages. Additionally, the version numbers for the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
ios/kommunicate_flutter.podspec (1)
Line range hint
6-6
: Update the podspec version to match the release versionThe podspec version is set to '0.0.1' while this PR is for release v1.9.8. This inconsistency should be fixed to maintain proper versioning across the package.
Apply this diff to fix the version:
- s.version = '0.0.1' + s.version = '1.9.8'
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
CHANGELOG.md
(1 hunks)README.md
(1 hunks)ios/kommunicate_flutter.podspec
(1 hunks)pubspec.yaml
(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- README.md
- pubspec.yaml
🔇 Additional comments (1)
ios/kommunicate_flutter.podspec (1)
20-20
: LGTM! Verify the changelog for version 7.2.3
The update to Kommunicate iOS SDK 7.2.3 aligns with the PR objectives to fix the date and time format in postback messages for iOS.
Let's verify the changelog entries for this version:
✅ Verification successful
Changelog verified for Kommunicate iOS SDK v7.2.3
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the changelog entries for Kommunicate iOS SDK v7.2.3
# Fetch the changelog or release notes from GitHub
gh api \
-H "Accept: application/vnd.github+json" \
repos/Kommunicate-io/Kommunicate-iOS-SDK/releases/tags/7.2.3
Length of output: 2067
## 1.9.8 | ||
- Fixed response with date and time format in postback message. (iOS) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Document all changes in the changelog.
The changelog entry is missing the iOS SDK version update to 7.2.3, which is mentioned in the PR description.
Consider updating the changelog to include all changes and follow the consistent format used in previous entries:
## 1.9.8
-Fixed response with date and time format in postback message. (iOS)
+### iOS
+- Fixed response with date and time format in postback message
+- Updated iOS SDK version to 7.2.3
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
## 1.9.8 | |
- Fixed response with date and time format in postback message. (iOS) | |
## 1.9.8 | |
### iOS | |
- Fixed response with date and time format in postback message | |
- Updated iOS SDK version to 7.2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Summary by CodeRabbit
Release Notes for Version 1.9.8
Bug Fixes
Dependency Updates
kommunicate_flutter
dependency version from^1.9.7
to^1.9.8
.Kommunicate
dependency version from~> 7.2.2
to~> 7.2.3
.These updates ensure improved functionality and compatibility across both iOS and Android platforms.