Ensure filtered_attributes and filtered_optimistic are also regex #13047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some further discussion on #12988 after it got merged pointing out that
filtered_cache
, unlike the otherfiltered_*
is regex based.Having it as a regex is actually more flexible, so this PR updates
filtered_attributes
andfiltered_optimistic
to also be regex based.For testing I kept my exiting config unchanged and noticed everything still worked, then I added ^ and $ anchors and everything also still worked, providing a 'bare' attribute name mostly will still work fine, unless something like 'color' is provided it will now match attribute containing color in the name.
Further testing nothing broke on a test network with a single bulb: