Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting tab interface completely broken after 1.33.1 update #19317

Closed
DmitriK opened this issue Oct 17, 2023 · 24 comments
Closed

Reporting tab interface completely broken after 1.33.1 update #19317

DmitriK opened this issue Oct 17, 2023 · 24 comments
Labels
problem Something isn't working

Comments

@DmitriK
Copy link

DmitriK commented Oct 17, 2023

What happened?

After upgrading to 1.33.1, my VINDSTYRKA devices were no longer updating at the rate that I had previously configured them. Upon going to the reporting tab, I noticed that all the clusters were listed twice, once with my original settings, and once with what appears to be the default. It also appears to be impossible to fix. I can disable all the extra entries except for pm25measurement, where I first have to change the attribute to measuredValueIkea, otherwise I get a Request 'zigbee2mqtt/bridge/request/device/configure_reporting' failed with error: 'ConfigureReporting 0x385cfbfffea36292/1 pm25Measurement([{"attribute":"measuredValue","minimumReportInterval":60,"maximumReportInterval":65535,"reportableChange":2}], {"sendWhen":"immediate","timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'INVALID_DATA_TYPE')'
However, attempting to change any of the settings results in more duplicates returning, though they seem to match my settings.
Screenshot of what this looks like after any attempt at editing:
image

What did you expect to happen?

A) zigbee2mqtt does not erase my previous reporting settings
B) I can actually use the reporting tab to adjust the settings.

How to reproduce it (minimal and precise)

Unsure what the minimum requirement is. As mentioned above, I'm using VINDSTYRKA devices (don't know if it's specific to them), and simply trying to set reporting settings.

Zigbee2MQTT version

1.33.1

Adapter firmware version

0x26580700

Adapter

ConBee2/RaspBee2

Debug log

log.txt

@DmitriK DmitriK added the problem Something isn't working label Oct 17, 2023
@sanyafifa
Copy link

sanyafifa commented Oct 31, 2023

I connected my new sensor E2112 yesterday - and there is no data from it except LQI.
image

Zigbee2MQTT version
1.33.1 dev

@alexh3o
Copy link

alexh3o commented Nov 8, 2023

Hi,
After noticing my ZLinky did'nt update properly for some values, I noticed the same problem in reporting page.
Some duplicates can be deleted, others not, and when I try to change a value (min rep interval or min rep change), a duplicate reporting is added again instead of changing the adequate line.
This is on a raspberry pi 4 and HA supervised:
Core 2023.11.1
Supervisor 2023.11.0
Frontend 20231030.
Zigbee2mqtt 1.33.2

image

@Koenkk
Copy link
Owner

Koenkk commented Nov 8, 2023

@alexh3o could you provide your data/database.db?

@alexh3o
Copy link

alexh3o commented Nov 8, 2023

Here is the part for ZLinky

{"id":58,"type":"Router","ieeeAddr":"0x00158d000966cc3e","nwkAddr":43723,"manufId":4151,"manufName":"LiXee","powerSource":"Mains (single phase)","modelId":"ZLinky_TIC\u0000","epList":[1,242],"endpoints":{"1":{"profId":260,"epId":1,"devId":83,"inClusterList":[0,3,1794,2820,2817,65382,1],"outClusterList":[25],"clusters":{"genBasic":{"attributes":{"modelId":"ZLinky_TIC\u0000","manufacturerName":"LiXee","powerSource":1,"zclVersion":3,"appVersion":12,"stackVersion":2,"hwVersion":1,"dateCode":"20230214","swBuildId":"4000-0013"}},"liXeePrivate":{"attributes":{"linkyMode":0,"currentTarif":"BASE\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000","warnDPS":0}},"haElectricalMeasurement":{"attributes":{"rmsCurrentMax":90,"apparentPower":1950,"rmsCurrent":7}},"seMetering":{"attributes":{"meterSerialNumber":{"type":"Buffer","data":[48,51,49,55,54,50,48,52,53,49,49,53]},"activeRegisterTierDelivered":"TH..","currentSummDelivered":[0,39755333]}},"haMeterIdentification":{"attributes":{"availablePower":60}}},"binds":[{"cluster":1794,"type":"endpoint","deviceIeeeAddress":"0x00124b0024c82c76","endpointID":1},{"cluster":2817,"type":"endpoint","deviceIeeeAddress":"0x00124b0024c82c76","endpointID":1},{"cluster":2820,"type":"endpoint","deviceIeeeAddress":"0x00124b0024c82c76","endpointID":1},{"cluster":65382,"type":"endpoint","deviceIeeeAddress":"0x00124b0024c82c76","endpointID":1}],"configuredReportings":[{"cluster":1794,"attrId":0,"minRepIntval":60,"maxRepIntval":900,"repChange":100},{"cluster":2820,"attrId":1288,"minRepIntval":60,"maxRepIntval":900,"repChange":1},{"cluster":2820,"attrId":1295,"minRepIntval":60,"maxRepIntval":900,"repChange":1},{"cluster":65382,"attrId":5,"minRepIntval":60,"maxRepIntval":900,"repChange":1},{"cluster":65382,"attrId":5,"minRepIntval":60,"maxRepIntval":900,"repChange":1,"manufacturerCode":null},{"cluster":1794,"attrId":0,"minRepIntval":60,"maxRepIntval":900,"repChange":10,"manufacturerCode":null},{"cluster":2820,"attrId":1295,"minRepIntval":15,"maxRepIntval":900,"repChange":1,"manufacturerCode":null}],"meta":{}},"242":{"profId":41440,"epId":242,"devId":97,"inClusterList":[33],"outClusterList":[33],"clusters":{},"binds":[],"configuredReportings":[],"meta":{}}},"appVersion":12,"stackVersion":2,"hwVersion":1,"dateCode":"20230214","swBuildId":"4000-0013","zclVersion":3,"interviewCompleted":true,"meta":{"configured":1745911956},"lastSeen":1699468392019,"defaultSendRequestWhen":"immediate"}

I can send the whole database.db if it's useful, should I do it here or through a more private channel ?

@seblu
Copy link

seblu commented Dec 1, 2023

I'm also affected by this. In my case, duplication occurs when I'm updating values in the Reporting tab.

@seblu
Copy link

seblu commented Dec 1, 2023

Same issue with freshly released 1.34.0. Despite no error reported, it looks like it happens when the original value cannot be changed.

After updating activePower min rep change value from 10 to 1:

  • A new line is added at the bottom with the requested value.
  • The old line remain with its value field updated to the requested value.
    Screenshot_20231201_124719

After a page reload, value is back and new row is still here:

  • The original line value has changed to the original value. As if it has not changed.
  • The new line remain with the requested value.
    Screenshot_20231201_124805

I can remove the new line. On another device, the same behavior was fixed by repairing (removing/pairing).

@alexh3o
Copy link

alexh3o commented Dec 1, 2023

Hi, if you remove and repair your device, you can configure reporting without having duplicates after ?

@emandtf
Copy link

emandtf commented Dec 1, 2023

Just updated to 1.34.0 and now (without doing anything) many "entities" in database.db are duplicated and reported with default/wrong Reporting times/repo_changes together with the new "manufacturerCode: null" JSON attribute.....

Those duplicated entities are the same that was previously affected by this duplication bug when we was trying to update their values.

A questions: should we keep the ones with "manufacturerCode: null" (because it's the new/right standard ATM) or the old ones without this new attribute?

@Koenkk
Copy link
Owner

Koenkk commented Dec 3, 2023

Pushed a fix! After upgrading, click Apply on the configured reportings to get rid of the duplicates.

Changes will be available in the dev branch in a few hours from now. (https://www.zigbee2mqtt.io/advanced/more/switch-to-dev-branch.html)

@Koenkk Koenkk closed this as completed Dec 3, 2023
@emandtf
Copy link

emandtf commented Dec 4, 2023

Pushed a fix! After upgrading, click Apply on the configured reportings to get rid of the duplicates.

Changes will be available in the dev branch in a few hours from now. (https://www.zigbee2mqtt.io/advanced/more/switch-to-dev-branch.html)

Unfortunately switching to Dev branch doesn't solve anything. Now Z2M neither starts.....

zigbee2mqtt@1.34.0-dev start
node index.js
Building Zigbee2MQTT... (initial build), failed
Error: Command failed: npm run build
at ChildProcess.exithandler (node:child_process:419:12)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1091:16)
at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)

@Koenkk
Copy link
Owner

Koenkk commented Dec 4, 2023

Can you try to execute rm -f tsconfig.tsbuildinfo in the z2m folder first?

@emandtf
Copy link

emandtf commented Dec 5, 2023

Different error but unable to run Z2M.

zigbee2mqtt@1.34.0-dev start
node index.js
Building Zigbee2MQTT... (hash changed), failed
Error: Command failed: npm run build
at ChildProcess.exithandler (node:child_process:419:12)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1091:16)
at Socket. (node:internal/child_process:449:11)
at Socket.emit (node:events:513:28)
at Pipe. (node:net:321:12)

@Koenkk
Copy link
Owner

Koenkk commented Dec 5, 2023

What if you execute npm run build?

@emandtf
Copy link

emandtf commented Dec 7, 2023

What if you execute npm run build?

Using latest DEV there isn't any issue during start.
Duplicated entities seems gone when I clicked "Apply" to some of those values.

Just a small "glitch": just after click "Apply" the duplicated entry still remains there, but a page refresh fixes this.

@nplawes
Copy link

nplawes commented Dec 19, 2023

docker exec -it z2m grep version package.json
  "version": "1.34.0",

I appear to be running the "fixed" version, but pressing "Apply" does not fix the issue for me (even after a page refresh)

Also tried on a device without duplicates... I now have duplicates :-(

@seblu
Copy link

seblu commented Dec 20, 2023

Same here. I tried few days ago and duplication is still here.

@Koenkk
Copy link
Owner

Koenkk commented Dec 21, 2023

@nplawes

Also tried on a device without duplicates... I now have duplicates :-(

Could you provide the data/database.db entry of this device?

@nplawes
Copy link

nplawes commented Dec 21, 2023 via email

@emandtf
Copy link

emandtf commented Dec 21, 2023

I'm not sure which version broke

Are you sure you're running 1.34-dev version?
My duplicated values were fixed just by pressing "Apply" on those values, and then refresh the web page.

@nplawes
Copy link

nplawes commented Dec 21, 2023 via email

@emandtf
Copy link

emandtf commented Dec 21, 2023

I don't see a docker tag for 1.34-dev. There is a latest-dev, which hopefully is stable enough to not break my live environment

Don't try on a production environment. Dev branch could be often broken and doesn't allow to start.

@nplawes
Copy link

nplawes commented Dec 21, 2023 via email

@Koenkk
Copy link
Owner

Koenkk commented Dec 22, 2023

Ah I forgot this fix did not made it into 1.34.0, fix will be included in the 1 January release.

@nplawes
Copy link

nplawes commented Dec 22, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants