-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Holding volume buttons on IKEA Symfonisk E2123 remote sometimes results in delayed/outdated events #17195
Comments
CC'ing @ilueckel to see if they suffer from this as well or not (given that they contributed Koenkk/zigbee-herdsman-converters#5583) |
For me it's not only on holding. Whenever I press volume_up a few times the commands are issued instantly, but then after 1-2 seconds it executes it anoter 1-2 times. |
Sadly I can not recreate the behavior with my remote. |
I have that as well, but the holding down is easier to reproduce. |
In the zigbee message payload we get back from the device, it includes a counter so we know the order of the button press events. In theory, it would be possible to fix this issue in the zigbee-herdsman-converter by ensuring that we only process a button action when the counter is higher than the last one seen (modulo 1 byte). |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days |
I can reproduce the behavior. Having here a E2123 with stock 1.0.012 and one I updated to 1.0.35. I think that the counters @junosuarez mentioned are only implemented for the dot buttons or did I miss something. Is it possible that I configured something wrong or does someone know if it is possible to downgrade the device to stock firmware? |
Check if the transactionID has already been used. Fixes Koenkk/zigbee2mqtt#17195
One of my remotes is now also affected by this error. Here is my herdsman debug log
This log shows three actions zigbee2mqtt publishes, although the button is only pressed one time. As seen from the logs, the coordinator receives the message three times - so I guess this an bug from the remote? In contrast to the description before, my error also triggers on simple press. My finding so far is that the |
* Update ikea.ts Check if the transactionID has already been used. Fixes Koenkk/zigbee2mqtt#17195 * Update ikea.ts Applied code style of other converters
What happened?
When pressing (or holding) the volume up/down buttons on the remote, you can observe that previous (outdated) events are sometimes mixed-in with current ones.
The easiest to reproduce this is by holding eg volume up for some time and then switching to pressing the volume down button (a few times).
At first I thought this was an issue in HA, but when checking the raw MQTT feed it is visible there as well + you can see it in the logs too.
Unsure if this issue is caused by the actual remote or some kind of buffering in zigbee2mqtt/zigbee coordinator stack.
What did you expect to happen?
The order of events should be correct and no outdated events should be delivered when they no longer make sense.
How to reproduce it (minimal and precise)
Pair IKEA Symfonisk Gen2 remote (E2123) with zigbee2mqtt, hold the volume up button for some time and then switch to pressing the volume down button (a few times).
You'll see that instead of the expected
[volume_up_hold, volume_up_hold, volume_up_hold, volume_down, volume_down]
stream. you might get something like[volume_up_hold, volume_up_hold, volume_up_hold, volume_down, volume_up_hold, volume_up_hold, volume_down]
.Zigbee2MQTT version
1.30.2-dev commit: 1368a78
Adapter firmware version
20220219
Adapter
SONOFF Zigbee 3.0 USB Dongle Plus ZBDongle-P
Debug log
Attempt 1, holding volume up followed by volume down presses:
Attempt 2, holding volume down, followed by volume up presses:
The text was updated successfully, but these errors were encountered: