[ember] Increase default NCP config + edge case device leave support #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Koenkk Please confirm controller test/logic as expected. PS: I have to fix that darn coverage bug on my machine :( |
Koenkk
reviewed
Mar 11, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some more firmware current defaults for reference + links.
Increase default NCP configuration for max children and binding table. The changes are pretty drastic, but the initial values were actually very low compared to all the firmware defaults out there.
Allow Z2M to know when an ID conflict forced the stack to remove devices (edge case scenario). Allow lookup by network address in
Controller>onDeviceLeaveto make this work without extra NCP call.Move default APS options to const.