Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump serialport from 9.2.8 to 10.4.0 #607

Merged
merged 5 commits into from
Dec 4, 2022
Merged

Conversation

jirutka
Copy link
Contributor

@jirutka jirutka commented Nov 9, 2022

No description provided.

@jirutka jirutka force-pushed the bump-serialport branch 2 times, most recently from af394d9 to d61d5df Compare November 9, 2022 23:03
serialport already provides TS types, so @types/serialport is not
needed anymore.
To remove several unused dependencies.
@Koenkk
Copy link
Owner

Koenkk commented Nov 10, 2022

This was previously attempted in https://github.com/Koenkk/zigbee-herdsman/pull/504/files but caused issues: Koenkk/zigbee2mqtt#11545 . Seems to be related to serialport/node-serialport#2438 which has not been fixed yet.

@Koenkk
Copy link
Owner

Koenkk commented Dec 4, 2022

Serialport 10.5.0 has been released in the meantime. Lets hope the issue is fixed now.

Also thanks for the cleanup! (less dependencies 😄 )

@Koenkk Koenkk merged commit 9337083 into Koenkk:master Dec 4, 2022
@zegl
Copy link
Contributor

zegl commented Dec 5, 2022

This upgrade does not seem to have worked. I was just doing some testing of zigbee2mqtt's latest dev branch on arm/v7, and the again the app crashes during boot.

Edit: I'll do some more testing to see if I can get it to work again without downgrading this dependency.

Edit2: No luck. 🤔 Here are the logs I get before the program crashes:

Using '/app/data' as data directory
Zigbee2MQTT:debug 2022-12-05 15:22:36: Loaded state from file /app/data/state.json
Zigbee2MQTT:info  2022-12-05 15:22:36: Logging to console and directory: '/app/data/log/2022-12-05.15-22-35' filename: log.txt
Zigbee2MQTT:debug 2022-12-05 15:22:36: Removing old log directory '/app/data/log/2022-12-05.15-06-26'
Zigbee2MQTT:info  2022-12-05 15:22:36: Starting Zigbee2MQTT version 1.28.4-dev (commit #)
Zigbee2MQTT:info  2022-12-05 15:22:36: Starting zigbee-herdsman (0.14.77)
Zigbee2MQTT:debug 2022-12-05 15:22:36: Using zigbee-herdsman with settings: '{"adapter":{"concurrent":null,"delay":null,"disableLED":false},"backupPath":"/app/data/coordinator_backup.json","databaseBackupPath":"/app/data/database.db.backup","databasePath":"/app/data/database.db","network":{"channelList":[11],"extendedPanID":[221,221,221,221,221,221,221,221],"networkKey":"HIDDEN","panID":6754},"serialPort":{"path":"/dev/ttyACM0"}}'
2022-12-05T14:22:36.691Z serialport/bindings-cpp loading LinuxBinding
2022-12-05T14:22:37.513Z serialport/bindings-cpp list
2022-12-05T14:22:37.890Z serialport/bindings-cpp list
2022-12-05T14:22:38.186Z zigbee-herdsman:adapter Path '/dev/ttyACM0' is valid for 'DeconzAdapter'
2022-12-05T14:22:38.204Z zigbee-herdsman:deconz:driver Set delay to 0
2022-12-05T14:22:38.216Z zigbee-herdsman:controller:log Starting with options '{"network":{"networkKeyDistribute":false,"networkKey":[XXXX],"panID":6754,"extendedPanID":[221,221,221,221,221,221,221,221],"channelList":[11]},"serialPort":{"path":"/dev/ttyACM0"},"databasePath":"/app/data/database.db","databaseBackupPath":"/app/data/database.db.backup","backupPath":"/app/data/coordinator_backup.json","adapter":{"disableLED":false,"concurrent":null,"delay":null}}'
2022-12-05T14:22:38.222Z zigbee-herdsman:deconz:driver Opening with /dev/ttyACM0
2022-12-05T14:22:38.241Z serialport/stream opening path: /dev/ttyACM0
2022-12-05T14:22:38.245Z serialport/bindings-cpp open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants