-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump serialport from 9.2.8 to 10.4.0 #607
Conversation
af394d9
to
d61d5df
Compare
serialport already provides TS types, so @types/serialport is not needed anymore.
d61d5df
to
5de0173
Compare
To remove several unused dependencies.
This was previously attempted in https://github.com/Koenkk/zigbee-herdsman/pull/504/files but caused issues: Koenkk/zigbee2mqtt#11545 . Seems to be related to serialport/node-serialport#2438 which has not been fixed yet. |
Serialport 10.5.0 has been released in the meantime. Lets hope the issue is fixed now. Also thanks for the cleanup! (less dependencies 😄 ) |
This upgrade does not seem to have worked. I was just doing some testing of zigbee2mqtt's latest Edit: I'll do some more testing to see if I can get it to work again without downgrading this dependency. Edit2: No luck. 🤔 Here are the logs I get before the program crashes:
|
No description provided.