-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Green spring cleaning #1349
Conversation
|
It's really just that key that's the problem, don't think it's worth adding another object. Maybe directly as |
Also fine! |
🚀 |
9e251f0
9e245ab
UNPROCESSED
and withFULLENCR
options
from deconz/emberImportant
FULLENCR mode is rarely used, and devices that do (namely Moes ZEU2S), appear to misbehave in other ways (non-fixed source ID?)... Implementation is purely based on data gathered from Koenkk/zigbee2mqtt#19405 (comment) (ember) and the GP spec. It needs testing with actual devices. Also, with the data being limited compared to having the full NWK GP frame, this will only work if the stack passes the proper information. The codepath is guarded as much as possible, so, worse case scenario, it just shouldn't trigger.
decommissioning
(0xe1), in same way as regular device leave (tested/confirmed with PTM216Z)@Koenkk
storing of thegpSecurityKey
indevice.meta
isn't all that great, but since devices pass it during commissioning and it's not available in followingUNPROCESSED
frames, we need to store it somehow...?Also this is supposed to be the frame counter, but instead it has been using source ID!?
CC: @chris-1243