Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NodeJS 6 #6

Closed
kirovilya opened this issue Jul 8, 2019 · 2 comments
Closed

Support NodeJS 6 #6

kirovilya opened this issue Jul 8, 2019 · 2 comments

Comments

@kirovilya
Copy link
Contributor

For use in the iobroker project, I would like to support nodejs starting from 6.
Therefore, I propose to rewrite the async-functions.
@Koenkk
Copy link
Owner

Koenkk commented Jul 8, 2019 •
edited
Loading

I understand however nodejs 6 is not maintained anymore, I would suggest to update to nodejs 10 (as support for nodejs 8 will also drop in the end of the year).

https://github.com/nodejs/Release

EDIT: The iobroker documentation says The currently recommended version is node 8.x; with js-controller 1.5.7 also node 10.x, then in step 4.1. replace the "8.x" against 10.x ".. (https://www.iobroker.net/#en/documentation/install/linux.md#installationnodejs), so I expect this is not a problem?

@kirovilya
Copy link
Contributor Author

This is the recommended version, but there are already many installations for version 6. :(
ok. thank

Koenkk pushed a commit that referenced this issue Jan 9, 2024
@slugzero
fix: Improve request queue behavior #6 (#860)
746fafb 
* Same send behavior for sendWhen=active and fastpoll

* remove sendWhen from endpoint.ts

* also remove defaultSendRequestWhen

* remove tests that are no longer needed, fix coverage, rename tests

* lint

* add defaultSendRequestWhen compatibility setter

* Revert "add defaultSendRequestWhen compatibility setter"

This reverts commit 8200aea.
@Koenkk Koenkk mentioned this issue Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Koenkk @kirovilya