fix: Add missing response ID to view command (#1181)

Koenkk · Sep 9, 2024 · fc229cc · fc229cc
1 parent 2e948a9
commit fc229cc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/zspec/zcl/definition/cluster.ts b/src/zspec/zcl/definition/cluster.ts
@@ -142,6 +142,7 @@ export const Clusters: Readonly<Record<ClusterName, Readonly<ClusterDefinition>>
             },
             view: {
                 ID: 1,
+                response: 1,
                 parameters: [{name: 'groupid', type: DataType.UINT16}],
             },
             getMembership: {

diff --git a/test/controller.test.ts b/test/controller.test.ts
@@ -4384,7 +4384,7 @@ describe('Controller', () => {
                         ],
                         name: 'add',
                     },
-                    view: {ID: 1, parameters: [{name: 'groupid', type: 33}], name: 'view'},
+                    view: {ID: 1, response: 1, parameters: [{name: 'groupid', type: 33}], name: 'view'},
                     getMembership: {
                         ID: 2,
                         response: 2,
@@ -5238,7 +5238,7 @@ describe('Controller', () => {
                         ],
                         name: 'add',
                     },
-                    view: {ID: 1, parameters: [{name: 'groupid', type: 33}], name: 'view'},
+                    view: {ID: 1, response: 1, parameters: [{name: 'groupid', type: 33}], name: 'view'},
                     getMembership: {
                         ID: 2,
                         response: 2,
@@ -5347,7 +5347,7 @@ describe('Controller', () => {
                         ],
                         name: 'add',
                     },
-                    view: {ID: 1, parameters: [{name: 'groupid', type: 33}], name: 'view'},
+                    view: {ID: 1, response: 1, parameters: [{name: 'groupid', type: 33}], name: 'view'},
                     getMembership: {
                         ID: 2,
                         response: 2,
@@ -5443,7 +5443,7 @@ describe('Controller', () => {
                         ],
                         name: 'add',
                     },
-                    view: {ID: 1, parameters: [{name: 'groupid', type: 33}], name: 'view'},
+                    view: {ID: 1, response: 1, parameters: [{name: 'groupid', type: 33}], name: 'view'},
                     getMembership: {
                         ID: 2,
                         response: 2,
@@ -6672,7 +6672,7 @@ describe('Controller', () => {
                         ],
                         name: 'add',
                     },
-                    view: {ID: 1, parameters: [{name: 'groupid', type: 33}], name: 'view'},
+                    view: {ID: 1, response: 1, parameters: [{name: 'groupid', type: 33}], name: 'view'},
                     getMembership: {
                         ID: 2,
                         response: 2,