Skip to content

Commit

Permalink
fix(ignore): Fix not awaited promise in `implicitCheckin (#1099)
Browse files Browse the repository at this point in the history
* fix(ignore): Fix not awaited promise in `implicitCheckin

* fix coverage
  • Loading branch information
Koenkk authored Jun 30, 2024
1 parent 75e4f15 commit 6d2ee88
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/controller/model/device.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,9 @@ class Device extends Entity {
}

public implicitCheckin(): void {
this.endpoints.forEach(async e => e.sendPendingRequests(false));
// No need to do anythign in `catch` as `endpoint.sendRequest` already logs failures.
/* istanbul ignore next */
Promise.allSettled(this.endpoints.map((e) => e.sendPendingRequests(false))).catch(() => {});
}

public updateLastSeen(): void {
Expand Down

0 comments on commit 6d2ee88

Please sign in to comment.