Ported Custom Philips Clusters From Herdsman To ModernExtends #8882
+46
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrivers
reviewed
Feb 24, 2025
danieledwardgeorgehitchcock
force-pushed
the
philips_modern_extends_clusters
branch
from
2629ee7 to
d62e862
Compare
danieledwardgeorgehitchcock
force-pushed
the
philips_modern_extends_clusters
branch
2 times, most recently
from
8dabe6f to
d62e862
Compare
chrivers
reviewed
Feb 25, 2025
danieledwardgeorgehitchcock
force-pushed
the
philips_modern_extends_clusters
branch
from
eda9e90 to
d62e862
Compare
danieledwardgeorgehitchcock
force-pushed
the
philips_modern_extends_clusters
branch
from
618d0f4 to
8e7b203
Compare
danieledwardgeorgehitchcock
force-pushed
the
philips_modern_extends_clusters
branch
from
047db09 to
8e7b203
Compare
chrivers
reviewed
Feb 26, 2025
danieledwardgeorgehitchcock
force-pushed
the
philips_modern_extends_clusters
branch
from
1dde87f to
4933a1c
Compare
Koenkk
reviewed
Mar 1, 2025
| @@ -94,7 +94,29 @@ const philipsModernExtend = { | |||
| result.exposes.push(...exposeEndpoints(e.enum("effect", ea.SET, effects), args.endpointNames)); | |||
| } | |||
|
|
|||
| const customCluster = m.deviceAddCustomCluster("manuSpecificPhilips3", { | |||
| const customClusterFC00 = m.deviceAddCustomCluster("manuSpecificPhilips", { | |||
There was a problem hiding this comment.
This code is only executed for Philips devices using philipsLight(), there are also e.g. plugs and motion sensors that have these clusters. Maybe we should create a new philipsCustomClusters() modern extend?
There was a problem hiding this comment.
Thanks for the review! I'll get right on it!
|
Note to self; after this merge Koenkk/zigbee-herdsman#1326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft pull request intended to begin the moving of
manufacturerSpecificclusters out of the Herdsman Clusters specification and into themodernExtendsformat in preparation for some larger re-factoring taking place for the work done by @chrivers in the Bifrost project.At present, this is just a lift and drop of the cluster specs as they are in Herdsman (will create a separate PR in that repo for removal).
Once I have got this over the line, I will begin porting across the newly documented cluster attributes / commands / responses