Heimgard SLM2 - Locking history for internal vs external lock status #8864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Feb 21, 2025
| @@ -1,11 +1,13 @@ | |||
| import fz from '../converters/fromZigbee'; | |||
| import tz from '../converters/toZigbee'; | |||
| import * as exposes from '../lib/exposes'; | |||
| import * as h from '../lib/heimgard'; | |||
There was a problem hiding this comment.
Suggested change
| import * as h from '../lib/heimgard'; | |
| import * as heimgard from '../lib/heimgard'; |
Koenkk
reviewed
Feb 21, 2025
| }, | ||
| exposes: [e.lock(), e.pincode(), e.battery(), e.sound_volume()], | ||
| extend: [h.slm_2.soundVolume()], |
There was a problem hiding this comment.
Use some more modernExtends here, e.g. m.battery(), m.lock() m.forcePowerSource({powerSource: 'Battery'}),
There was a problem hiding this comment.
with m.forcePowerSource({powerSource: 'Battery'}),. I Dont need the part in configure right?
There was a problem hiding this comment.
Also. Since modern m.lock() includes lock_sound_volume. how do i exclude this?
There was a problem hiding this comment.
with m.forcePowerSource({powerSource: 'Battery'}),. I Dont need the part in configure right?
Exactly
Also. Since modern m.lock() includes lock_sound_volume. how do i exclude this?
You can add a parameter to the modernExtend.ts/lock to disable this conditionally.
Koenkk
reviewed
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the limited functionality of the device, and no documentation, there is no way to pull correct data at all.
If the function key on the inside is pressed the whole locks status will change, even though the exterior locking is unlocked, the device will for example say that it is locked. This code attempts to work around the issue by keeping a local history of the states and executor.
Sound volume is now mapped against the correct values for this device.
Other functionality is kept, but it does not work for this device (pin lock, user edit etc)
Battery will now show up in overview, but device has to bee reconfigured.
I've converted the code from my local converter at best effort, though I'm unsure how to test it locally for Z2M...
Suggestions are welcome