Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added temperature control accuracy attribute for the trvzb #8837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lcheng33775823
Copy link
Contributor

No description provided.

@@ -1318,6 +1319,24 @@ export const definitions: DefinitionWithExtend[] = [
valueStep: 1.0,
unit: '%',
}),
m.numeric({
name: 'temp_accuracy',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: 'temp_accuracy',
name: 'temperature_accuracy',

@photomoose
Copy link
Contributor

@lcheng33775823 this is great, I've been looking for a way to have more control over the hysteresis. Thanks.

FYI: I've also exposed the external temperature sensor attributes here: #8873

@marazmarci
Copy link
Contributor

marazmarci commented Feb 24, 2025

I think using the term "accuracy" can be a bit misleading, and can cause confusion without reading the description (for example only seeing the entity name in HA). A more accurate name could be "Temperature control hysteresis". Or would "hysteresis" be a too scientific term to use? 🤔

@shaggee
Copy link

shaggee commented Mar 2, 2025

Guys do you know if temp accuracy atribute will be added to next release?

@photomoose
Copy link
Contributor

Guys do you know if temp accuracy atribute will be add

Assuming @lcheng33775823 doesn't reply before, I'll pull these changes down tomorrow, test it, and make the changes as suggested by @Koenkk. Then it will likely be in the next release.

@bojanpotocnik
Copy link

bojanpotocnik commented Mar 3, 2025

and make the changes as suggested by @Koenkk

@photomoose what is your opinion on #8837 (comment) above?
I also think accuracy is a bit unusual wording for writable attribute representing hysteresis, tolerance, deadband, margin, ... Technically speaking, precision would be more correct than accuracy in this case 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants