-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added temperature control accuracy attribute for the trvzb #8837
base: master
Are you sure you want to change the base?
Conversation
@@ -1318,6 +1319,24 @@ export const definitions: DefinitionWithExtend[] = [ | |||
valueStep: 1.0, | |||
unit: '%', | |||
}), | |||
m.numeric({ | |||
name: 'temp_accuracy', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: 'temp_accuracy', | |
name: 'temperature_accuracy', |
@lcheng33775823 this is great, I've been looking for a way to have more control over the hysteresis. Thanks. FYI: I've also exposed the external temperature sensor attributes here: #8873 |
I think using the term "accuracy" can be a bit misleading, and can cause confusion without reading the description (for example only seeing the entity name in HA). A more accurate name could be "Temperature control hysteresis". Or would "hysteresis" be a too scientific term to use? 🤔 |
Guys do you know if temp accuracy atribute will be added to next release? |
Assuming @lcheng33775823 doesn't reply before, I'll pull these changes down tomorrow, test it, and make the changes as suggested by @Koenkk. Then it will likely be in the next release. |
@photomoose what is your opinion on #8837 (comment) above? |
No description provided.