-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for Bosch BTH-RM230Z #7484
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Thanks! |
@Koenkk Hmm, looks like zigbee-herdsman-converters/src/devices/bosch.ts Line 1435 in 3553dde
Seems the specified
|
Could you do a |
@Koenkk Here you go! 😊
|
The manufacturer code is missing from the custom cluster definition, try with: |
@Koenkk That was it! 🙌 |
No, zigbee-herdsman should use it automatically |
Thx, good to know! ✌️ What do you think about consolidating custom clusters, shared among different devices from the same manufacturer, into a single |
Yes, you can take Ubisys as an example:
|
Improve support for the Bosch thermostat by utilizing more default clusters and attributes.
Includes:
operating_mode
[ schedule | manual | pause ] (manufacturer-specific)system_mode
cool
modeauto
fromsystem_mode
(not supported by device)modernExtend
There's currently some duplicated code inbosch.ts
, but until I get to the Bosch TRV, we'll unfortunately have to live with that fact. 😅Fixes #7357
Relevant #6995