Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IKEA: try and be smart about dontDividePercentage #5465

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

sjorge
Copy link
Contributor

@sjorge sjorge commented Feb 12, 2023

Koenkk/zigbee2mqtt#16412

@Koenkk can you confirm 2.4.x is where IKEA change it?

My on/off ones are on 2.2.010 which is the last one with group binding support, dontDividePercentage=true is needed
My open/close that I got with my fyrtur are on 2.3.079, no group bind but they also seem to require dontDividePercentage=true

It seems the one form the issue was on 2.4.x so I picked that as the cutoff. For now anything < 2.4 has dontDividePercentage=true and everything else has it dontDividePercentage=false.

For my tests I had it at 2.3 so I could see if the code path was doing the right thing, and it was:

# 2.2.x
Zigbee2MQTT:debug 2023-02-12 14:17:19: Received MQTT message on 'zigbee2mqtt/remote/office/light_desk/get' with data '{"battery":""}'
Zigbee2MQTT:debug 2023-02-12 14:17:19: Publishing get 'get' 'battery' to 'remote/office/light_desk'
Zigbee2MQTT:debug 2023-02-12 14:17:22: Received Zigbee message from 'remote/office/light_desk', type 'readResponse', cluster 'genPowerCfg', data '{"batteryPercentageRemaining":74}' from endpoint 1 with groupID 0
Zigbee2MQTT:warn  2023-02-12 14:17:22: XXX: dontDividePercentage = true
Zigbee2MQTT:info  2023-02-12 14:17:22: MQTT publish: topic 'zigbee2mqtt/remote/office/light_desk', payload '{"battery":74,"linkquality":116,"update":{"installed_version":570492465,"latest_version":587699761,"state":"available"}}'

# 2.3.x
Zigbee2MQTT:debug 2023-02-12 14:17:33: Received MQTT message on 'zigbee2mqtt/remote/livingroom/side_back_window/get' with data '{"battery":""}'
Zigbee2MQTT:debug 2023-02-12 14:17:33: Publishing get 'get' 'battery' to 'remote/livingroom/side_back_window'
Zigbee2MQTT:debug 2023-02-12 14:17:37: Received Zigbee message from 'remote/livingroom/side_back_window', type 'readResponse', cluster 'genPowerCfg', data '{"batteryPercentageRemaining":87}' from endpoint 1 with groupID 0
Zigbee2MQTT:warn  2023-02-12 14:17:37: XXX: dontDividePercentage = false
Zigbee2MQTT:info  2023-02-12 14:17:38: MQTT publish: topic 'zigbee2mqtt/remote/livingroom/side_back_window', payload '{"battery":43.5,"linkquality":69,"update":{"installed_version":587699761,"latest_version":587699761,"state":"idle"}}'

I also added tz.battery_percentage_remaining as that made testing easier and no harm in having this, as it's quite useful to be able to trigger a refresh of the battery info (as always, you do have to wake up the device after)

move fzLocal.SYTRBAR_* to ikea.fz.* where all the others are located.
@Koenkk
Copy link
Owner

Koenkk commented Feb 13, 2023

I expect that it indeed broke at 2.4.x (e.g. Koenkk/zigbee2mqtt#16637).

Bedankt! 😄

@lorenzspenger
Copy link
Contributor

I think this fix should be incorporated into the roller blinds as well. My PRAKTLYSING and KADRILJ on 24.4.10 show the same behaviour.
E1926
E2102

@lorenzspenger
Copy link
Contributor

#5387

@sjorge sjorge deleted the ikea_battery branch February 14, 2023 11:07
@sjorge
Copy link
Contributor Author

sjorge commented Feb 14, 2023

I think this fix should be incorporated into the roller blinds as well. My PRAKTLYSING and KADRILJ on 24.4.10 show the same behaviour. E1926 E2102

I only have fyrtur but they don't seem to have a firmware newer that 2.3.088 available. Do your PRAKTLYSING and KADRILJ show a 24.4.* or is it 2.4.* like with the remotes?

@lorenzspenger
Copy link
Contributor

They both show 24.4.10. The fw was installed when I was using the Dirigera hub. It seems not to be released through the "official" channel z2m uses

@lorenzspenger
Copy link
Contributor

My remotes are also on 24.4.* fw. But the check for fw >2.3.x fixed the issue for my remotes as well.

sjorge added a commit to sjorge/zigbee-herdsman-converters that referenced this pull request Feb 15, 2023
Looks like people with the new hub get updates we're not getting via z2m for the ikea smart blind series.
The 24.x version also uses the new batteryPercentageRemaining values.

Koenkk#5465 (comment)
Koenkk pushed a commit that referenced this pull request Feb 15, 2023
Looks like people with the new hub get updates we're not getting via z2m for the ikea smart blind series.
The 24.x version also uses the new batteryPercentageRemaining values.

#5465 (comment)
@MattWestb
Copy link

I is getting update for the new motion sensor E1745 with Dirigera to version 24.4.5 and TFGW is having 2.0.022 as current (was moving it from TFGQ to Dirigera).
Its looks like Dirigera is using one other URL for OTA then with time machine its no update released for blinds ad the last Tradfri GW was releasing.
Hope some is sniffing the Dirigera OTA URL so we can getting updated for new devices that is not supported by TFGW.

@m-stefanski
Copy link

I have the same problem (battery reported as 200%) in my E1810.

OTA reports there is no newer firmware for it, it is on 1.2.223.
Is it something I can override for my specific device?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants